Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78766
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.179 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPhkiZzA7dgLGoOfWaj-gJzeSk17EKbMaJ9dV22JLxREPVJtRg@mail.gmail.com>
References: <CAGAGxbY+2G8zOWkHW7t_QhvFSFM=QLY7tSWJpGc8tAgpraLm-w@mail.gmail.com>
 <E336496D-4FEB-4B99-ABA6-AFF0F42E5339@gmail.com> <CAPwsocFVSBqju+jCSjOQeL3wFGbr=mLD6xC7jYh2u_RgQbOZeA@mail.gmail.com>
 <CAGAGxbbWU_=EFmMCq6YWdoB4P+OMtBS=xfL4W1-WFfyZxvKYAA@mail.gmail.com>
 <CAGAGxbbjSR0LKXKHKirzF=grEFRZD93get9+c8BAbK=fZ3VWzw@mail.gmail.com>
 <424081508.1350448.1415209726279.JavaMail.zimbra@escapemg.com>
 <801152711.1350497.1415209768109.JavaMail.zimbra@escapemg.com>
 <CAH-PCH6jjnoLRQs8xeONimuvcHzgL707modxOqxV1DFQvX7M4g@mail.gmail.com> <CAPhkiZzA7dgLGoOfWaj-gJzeSk17EKbMaJ9dV22JLxREPVJtRg@mail.gmail.com>
Date: Thu, 6 Nov 2014 10:42:35 +0900
Message-ID: <CAGa2bXYoG-WvqxyKeEQozz2Jq3Y9YBXpw4DyCcjr4fSYSmsrnw@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, Mark Caudill <mark.caudill@grooveshark.com>, 
	Yasuo Ohgaki <yohgaki@php.net>, julien pauli <jpauli@php.net>, Damian Wadley <php@requinix.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf303f6dfcf1d83b050726d145
Subject: Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--20cf303f6dfcf1d83b050726d145
Content-Type: text/plain; charset=UTF-8

Hi Andrey,

On Thu, Nov 6, 2014 at 8:23 AM, Andrey Andreev <narf@devilix.net> wrote:

> Short-term fix for 5.6 is obviously to revert the commit. I was vocal
> mostly because of principle at the time, but this issue is an example
> why.
>

Did you? I don't think so.

The reason that I didn't provide that user land "update" API is your
objection. If it is included, user had control even in this case.

A long-term "fix" for 5.6 would be what I've done in userland recently
> - continue to call SessionHandler::write() at all times, but _inside
> of it_ call touch() instead of fwrite() if there's no new data. That
> way custom session handlers wouldn't be affected, but the default one
> would still provide a performance boost. This is of course if we do
> want to keep the feature (I do), but considering that it was voted in
> a slightly different form ... I'm just being egoistic with this
> suggestion.
>

No. Providing userland update API just like C module save
handler is the way to go as I implemented at first.

Besides, the method that you described will not solve the issue reported
by the bug. There is no point that provides different API for C and PHP
written save handlers, IMO.

For PHP7 though, I definately want a redesign of the session APIs and
> it's on my TODO list for when I have some spare time to work on it.
>

I think you have misunderstanding for session management.

One example is that you don't understand nature of browser and server
communication. It's _asynchronous_ by it's nature, yet you insisted
_syncronous_ operation. Without this understanding, session cannot
be managed correctly/precisely.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--20cf303f6dfcf1d83b050726d145--