Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78761
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.208 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\))
In-Reply-To: <CAL+t6cHDLHjTE3JK0md=KZ=AnRns6iYxfphzA3qnShermVeOmg@mail.gmail.com>
Date: Thu, 6 Nov 2014 00:31:18 +0000
Cc: Patrick ALLAERT <patrickallaert@php.net>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <1DDB6E05-3143-4A74-8B13-AF85222579BA@ajf.me>
References: <CAL+t6cGt8B+X4ptWbyo6zm_xoyBOJC4QeiH6DjCxHX11CPWm_g@mail.gmail.com> <CACwt+JcYMS=+3t3e_JLHbNx-mgxUceiPOws2GZn9_QZ4HEo4Uw@mail.gmail.com> <CAL+t6cHDLHjTE3JK0md=KZ=AnRns6iYxfphzA3qnShermVeOmg@mail.gmail.com>
To: Sherif Ramadan <theanomaly.is@gmail.com>
Subject: Re: [PHP-DEV] New Standardized HTTP Interface
From: ajf@ajf.me (Andrea Faulds)


> On 5 Nov 2014, at 22:29, Sherif Ramadan <theanomaly.is@gmail.com> =
wrote:
>=20
> =46rom all the people I've spoken with that have a problem with =
handling PUT
> requests in PHP, it seems that they'd rather have PHP populate
> $_FILES/$_POST automatically in this case. Which would be relatively =
easy
> to do by modifying the default post reader function in the SAPI
> http://lxr.php.net/xref/PHP_5_6/main/php_content_types.c#51 however, =
that
> is itself a small BC break.
>=20
> Does anyone have any recommendations on what they think the best =
approach
> is? I'd appreciate any feedback/suggestions/constructive-criticism. =
Thanks!

I don=E2=80=99t think auto-populating for PUT/DELETE etc. is a good =
idea, they=E2=80=99re quite different semantically. If I send a DELETE =
request to code expecting a POST, and PHP pretends it=E2=80=99s a POST =
request, that=E2=80=99s bad.

However, I think the solution is simple: Add a function to do =
multipart/form-data parsing. Not a suite of functions, not a class, just =
one simple function. That way, for the few people that need it, they can =
do $_POST =3D =
multipart_form_data_parse(file_get_contents(=E2=80=98php://input')); and =
their problem=E2=80=99s solved.

If we can=E2=80=99t expose the parser, we could also just add a function =
to force population (force_parse_post_data() or something?). Again, this =
allows the few that need this to do so explicitly, but doesn=E2=80=99t =
make $_POST allow it for everyone else.
--
Andrea Faulds
http://ajf.me/