Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:78750 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8672 invoked from network); 5 Nov 2014 21:57:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Nov 2014 21:57:27 -0000 Authentication-Results: pb1.pair.com header.from=dunglas@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dunglas@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.171 as permitted sender) X-PHP-List-Original-Sender: dunglas@gmail.com X-Host-Fingerprint: 209.85.212.171 mail-wi0-f171.google.com Received: from [209.85.212.171] ([209.85.212.171:44807] helo=mail-wi0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D9/A2-27106-64D9A545 for ; Wed, 05 Nov 2014 16:57:26 -0500 Received: by mail-wi0-f171.google.com with SMTP id r20so1349405wiv.16 for ; Wed, 05 Nov 2014 13:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=BhVgaoJ/zLtgbSfZuVDgvJfplPDf/qKntP7Y4o0VzCU=; b=MbuxUF5Zyd6lFbVojviFhjoqB3Ov3K7zqVAX9zn65AZHMTSJ1VNRc9jDpiQGYWcXgI bkrekAnIPL/oGgvSe/UDfU/EQgWng7Z2bIXawQrWRCmYAv/RVpP0wEYKt9Cqm7mCPLVg P5NXBxVqV7Q9Ul2/+2uQtUucB7aKDMZSVFlUkOU61tel3nZL6IlbCrTH1T+1Jjf/rz+L i8tnUAFtCm28VVHQUjqkXKTqIGoD1xA4J8AEz3mHYVfJkCyraSdN9NXRHHzNVBhHSc4G 1HA2SusbSEWnPsobliuzRynwYl1pSlWPp46IGHZNODKlBtIS1DQclFTVJ2JuOKm22nt9 T2aQ== X-Received: by 10.180.91.70 with SMTP id cc6mr1159671wib.5.1415224643102; Wed, 05 Nov 2014 13:57:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.194.35.73 with HTTP; Wed, 5 Nov 2014 13:57:02 -0800 (PST) In-Reply-To: References: Date: Wed, 5 Nov 2014 22:57:02 +0100 Message-ID: To: Daniel Ribeiro Cc: PHP Internals Content-Type: multipart/alternative; boundary=f46d0438edd7215300050723aa58 Subject: Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL From: dunglas@gmail.com (=?UTF-8?Q?K=C3=A9vin_Dunglas?=) --f46d0438edd7215300050723aa58 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, According to the discussion on GitHub, I've made some changes on this PR: - Added a new FILTER_VALIDATE_DOMAIN filter validating domain names - Added a FILTER_FLAG_HOSTNAME flag to allow checking hostnames (_ are forbidden in hostname but not in domains) - Changed FILTER_VALIDATE_URL to use this new validator When https://github.com/php/php-src/pull/890 will be merged, it will be easy to add IDN support to this new domain validator. 2014-10-14 13:48 GMT+02:00 Daniel Ribeiro : > > Nice work man, it looks really good. > > > Daniel Ribeiro > http://danielribeiro.org > > On Tue, Oct 14, 2014 at 3:41 PM, K=C3=A9vin Dunglas w= rote: >> >> Hi, >> >> I opened a PR making FILTER_VALIDATE_URL more strict and more compliant >> with standards: https://github.com/php/php-src/pull/826 >> >> Can anyone review (and merge) this patch? >> >> Thanks! >> -- >> K=C3=A9vin Dunglas >> Consultant et d=C3=A9veloppeur freelance >> >> http://dunglas.fr >> T=C3=A9l. : 06 60 91 20 20 > > -- K=C3=A9vin Dunglas Consultant et d=C3=A9veloppeur freelance http://dunglas.fr T=C3=A9l. : 06 60 91 20 20 --f46d0438edd7215300050723aa58--