Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78739
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.48 as permitted sender)
MIME-Version: 1.0
Sender: are.you.winning@gmail.com
In-Reply-To: <CAEKnhAH-45cXajacrrXL3AS3uVnXiM2uM+gQMrNbqwn4boRTfQ@mail.gmail.com>
References: <CA+sv8zB4TC_N_cZ6W_CkGZLXhFNTw23z-R197qEOT1v-VR4ksQ@mail.gmail.com>
	<CAH-PCH7=SZ710Pz5o80YSNRiAyRHivnoYt-A_OZbApDH7Jxc3Q@mail.gmail.com>
	<CAEKnhAFrSd0dMMER6rYpw2Y-SS4wMF1SLS83C-44RdiYdg+HHg@mail.gmail.com>
	<CAGAGxbbzM1tMdsRSho_NAkf0aHd3gMTuQDur8-gi=5t5Lx3tgg@mail.gmail.com>
	<CAEKnhAEDkHQif+h=cDJGjmg+7c0DuGbYQmTo5ix=ULqzXE_pRg@mail.gmail.com>
	<CAGAGxbbaJ4hACmMXzkgG-XfV671ZCPF1bGJDNn7==D+YTUua8g@mail.gmail.com>
	<CAEKnhAH-45cXajacrrXL3AS3uVnXiM2uM+gQMrNbqwn4boRTfQ@mail.gmail.com>
Date: Wed, 5 Nov 2014 17:28:08 +0000
Message-ID: <CAGAGxbYcfu0EBmj-ba449avG7Cr77Z0mWRqz0QFvaFVo6P_f3Q@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Cc: Chris Wright <cw@daverandom.com>, Ferenc Kovacs <tyra3l@gmail.com>, Juan Basso <jrbasso@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1137c9283eeee805071fe7dc
Subject: Re: [PHP-DEV] Add a new flag for json_encode
From: cw@daverandom.com (Chris Wright)

--001a1137c9283eeee805071fe7dc
Content-Type: text/plain; charset=UTF-8

On 5 November 2014 17:21, Jakub Zelenka <bukka@php.net> wrote:

>
>
> On Wed, Nov 5, 2014 at 4:52 PM, Chris Wright <cw@daverandom.com> wrote:
>
>>
>> I'm sorry, but I don't understand why it would need to be deprecated. For
>> me "making it the default behaviour" would mean "changing the default value
>> of the $flags argument to JSON_PRESERVE_FACTIONAL_PART". The flag would
>> still function in exactly the same way - old code which pass flags
>> explicitly would continue to work in the same way, and any code which did
>> not want the new behaviour would only have to pass 0 to flags to get that
>> behaviour back.
>>
>>
>
> Then passing any flag will automatically disable it unless all current
> constants will be ORed with that value.
>
> It means if you set default as (options = JSON_PRESERVE_FACTIONAL_PART in
> zif_json_encode) and you pass just PHP_JSON_UNESCAPED_UNICODE then
> fractional part will be disabled (unless the constants are ORed). It's not
> really default like other defaults in json_encode because it's changed by
> any flag.
>
>
Indeed, but this is how anything else in PHP with a $flags argument
works... if I pass ENT_QUOTES to htmlspecialchars() it isn't handled as
ENT_COMPAT | ENT_HTML401 | ENT_QUOTES.

When you pass a $flags argument to a function explicitly, you are saying "I
don't want the default behaviour, I want more control", so I would be a
little surprised if my controlled options were suddenly changed and now I
have to add another flag to get the behaviour I wanted (and had before the
default value was changed).

Of course, this is just my view :-)

Thanks, Chris


> That being said if it's just me who doesn't like it and there are no other
> objection, I don't mind if it gets in. Let's just wait few days if there
> isn't anyone who also thinks that adding such feature to micro release is
> not the best idea...
>
> Cheers
>
> Jakub
>

--001a1137c9283eeee805071fe7dc--