Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78734
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.179 as permitted sender)
MIME-Version: 1.0
Sender: are.you.winning@gmail.com
In-Reply-To: <CAEKnhAEDkHQif+h=cDJGjmg+7c0DuGbYQmTo5ix=ULqzXE_pRg@mail.gmail.com>
References: <CA+sv8zB4TC_N_cZ6W_CkGZLXhFNTw23z-R197qEOT1v-VR4ksQ@mail.gmail.com>
	<CAH-PCH7=SZ710Pz5o80YSNRiAyRHivnoYt-A_OZbApDH7Jxc3Q@mail.gmail.com>
	<CAEKnhAFrSd0dMMER6rYpw2Y-SS4wMF1SLS83C-44RdiYdg+HHg@mail.gmail.com>
	<CAGAGxbbzM1tMdsRSho_NAkf0aHd3gMTuQDur8-gi=5t5Lx3tgg@mail.gmail.com>
	<CAEKnhAEDkHQif+h=cDJGjmg+7c0DuGbYQmTo5ix=ULqzXE_pRg@mail.gmail.com>
Date: Wed, 5 Nov 2014 16:52:55 +0000
Message-ID: <CAGAGxbbaJ4hACmMXzkgG-XfV671ZCPF1bGJDNn7==D+YTUua8g@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Cc: Chris Wright <cw@daverandom.com>, Ferenc Kovacs <tyra3l@gmail.com>, Juan Basso <jrbasso@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c11a685350ae05071f69a0
Subject: Re: [PHP-DEV] Add a new flag for json_encode
From: cw@daverandom.com (Chris Wright)

--001a11c11a685350ae05071f69a0
Content-Type: text/plain; charset=UTF-8

On 5 November 2014 16:45, Jakub Zelenka <bukka@php.net> wrote:

>
> On Wed, Nov 5, 2014 at 2:33 PM, Chris Wright <cw@daverandom.com> wrote
>>
>>
>> I'm afraid I have to disagree here, I don't like the idea of changing
>> this behaviour without making it controllable
>>
>
> If we make it default, then we could of course add a new constants that
> would allow the old behaviour.
>
> What I'm trying to say is that it doesn't make sense to add something to
> micro release and then change it (deprecate it) in PHP 7. I don't have
> problem with a new flag if the current behaviour stays but it should be
> decided before we make this change. There is no big hurry that we need to
> add it immediately.
>
>
I'm sorry, but I don't understand why it would need to be deprecated. For
me "making it the default behaviour" would mean "changing the default value
of the $flags argument to JSON_PRESERVE_FACTIONAL_PART". The flag would
still function in exactly the same way - old code which pass flags
explicitly would continue to work in the same way, and any code which did
not want the new behaviour would only have to pass 0 to flags to get that
behaviour back.


> Cheers
>
> Jakub
>

--001a11c11a685350ae05071f69a0--