Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78725
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 209.85.212.170 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAEbg-4bjQ-_WYbW-53G3RYcoC0LiG=wFLkBXjio26NsF3fR+XQ@mail.gmail.com>
References: <CALW=WECCELQOZpqB3foM6T+Qz+0v3hWT-mdTgCmGApEG4vxNcg@mail.gmail.com>
	<CAGAGxbZfDd5QaQ5iW+_pJzcHDHQztG_H_9JVyv4XT4BDaLVczw@mail.gmail.com>
	<CADUqk8UNnSL7C5_RDoNNFsdpuBoAFwdmzanaF9+GkeLN_gQkhQ@mail.gmail.com>
	<CAEZPtU44YsM1s_zJqPhAEu6cbqxh4k=A35qOd_z=XWErNf5wPA@mail.gmail.com>
	<5457AF2F.90808@php.net>
	<5457BDB7.8070701@garfieldtech.com>
	<CAFMT4NrgLzzpMt5Vm_Q84hXJ65U2jjqtLFm=ALYqwtiyxp0LjA@mail.gmail.com>
	<CAEZPtU4urLHc9FM0GohQJwkZD-TYKTVuPXcUMXsG5cAScHz3mw@mail.gmail.com>
	<54589A8D.3020607@sugarcrm.com>
	<CAEZPtU5qfcjCrcWRKW+ETF4uBp46rwVbv9nCdJoSUF+M+wKQdA@mail.gmail.com>
	<CAEPJdumXG9TC7xG8-YmGbQiwPMzwYvE_jXWvOQuNmz+U_=+ZaQ@mail.gmail.com>
	<1C3F4FA3-ABD5-4F6F-A898-F63AC1C723D5@ajf.me>
	<54591A76.8070302@sugarcrm.com>
	<967E30E5-71CB-40F8-9AE2-733D327DE197@ajf.me>
	<CAFp73XtxhW6t0k5TMa5n1ErC_7vur55Sa9oLtUM1P+X1Wugemg@mail.gmail.com>
	<545945A5.2090204@sugarcrm.com>
	<C12D441D-81CB-4270-8CE3-5A8BF2B27238@ajf.me>
	<CAFp73Xu++tT7fXE878i8CsibwNtiVJFcHQtzXi-iZA6=FXqeFA@mail.gmail.com>
	<CAFp73XuSaj4s3aqTfoOMCM6mAUM0BBncbRTyMW6uaMRgHhTphQ@mail.gmail.com>
	<CADyq6sLcYXxpyDzxrLVxS+5wgYYKh_TewgEcEAvg63p7LaNZqQ@mail.gmail.com>
	<CAEbg-4bjQ-_WYbW-53G3RYcoC0LiG=wFLkBXjio26NsF3fR+XQ@mail.gmail.com>
Date: Wed, 5 Nov 2014 17:07:37 +0100
Message-ID: <CAEPJdu=oaP3ZyePu2AkE14JdE7-7UT7HUgm7KOnUq3UpwAJ4FA@mail.gmail.com>
To: Alexander Lisachenko <lisachenko.it@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, 
	"guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>, Andrea Faulds <ajf@ajf.me>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, Pierre Joye <pierre.php@gmail.com>, 
	Levi Morrison <levim@php.net>, PHP internals <internals@lists.php.net>, 
	Larry Garfield <larry@garfieldtech.com>
Content-Type: multipart/alternative; boundary=f46d04138c9f52973b05071ec7fd
Subject: Re: [PHP-DEV] Annotation PHP 7
From: kontakt@beberlei.de (Benjamin Eberlei)

--f46d04138c9f52973b05071ec7fd
Content-Type: text/plain; charset=UTF-8

I think keeping this just like an array definition in a property would make
this both simple and flexible.

You can even improve on Marcos example with a class having constants:

namespace Doctrine\ORM\Mapping\Annotations;

class ORM
{
    const ENTITY = 'Doctrine\ORM\Mapping\Annotations\Entity';
    // more constants here
}

And then use it like:

use Doctrine\ORM\Mapping\Annotations\ORM;

[ORM::ENTITY => ["key" => "value"]]
class Article
{
}

This would allow projects to namespace their annotations without much
hassle. But it also allows people to disregard this and just write simple
strings as keys with the risk of clashes with third parties.

greetings
Benjamin

On Wed, Nov 5, 2014 at 4:15 PM, Alexander Lisachenko <
lisachenko.it@gmail.com> wrote:

>
> 2014-11-05 17:02 GMT+03:00 Marco Pivetta <ocramius@gmail.com>:
>
>> For example, this alternative approach perfectly fits the current
>> doctrine/annotations use-case:
>>
>> use Doctrine\ORM\Mapping\Entity;
>> use Doctrine\ORM\Mapping\Table;
>> use Doctrine\ORM\Mapping\Id;
>> use Doctrine\ORM\Mapping\GeneratedValue;
>> use Doctrine\ORM\Mapping\Column;
>>
>> [Entity::class => []]
>> [Table::class => ['name' => 'foo_table']]
>> class Foo
>> {
>>     [Id::class => []]
>>     [GeneratedValue::class => [GeneratedValue::UUID]]
>>     [Column::class => ['name' => 'bar_column', 'type' => 'string']]
>>     private $bar;
>> }
>>
>
> This looks great indeed for many reasons:
> 1) it's a simple array
> 2) it can be parsed with built-in DSL syntax for PHP, so any arbitrary
> evaluations with constants can be applied transparently, e.g.
> [Loggable::class => ['pointcut' => self::PREFIX . 'test' ]]
>
> 3) C# uses similar syntax with square brackets for annotations:
>
> public class Foo
> {
>     [Display(Name="Product Number")]
>     [Range(0, 5000)]
>     public int ProductID { get; set; }
> }
>
> However, I would like to see simple markers without nested associative
> arrays, e.g just put single AnnotationName::class into brackets or specify
> multiple annotations in one section:
>
> [Entity::class, Table::class => 'foo_table']
> class Foo
> {
>   // ...
> }
>

--f46d04138c9f52973b05071ec7fd--