Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78721
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFp73XuSaj4s3aqTfoOMCM6mAUM0BBncbRTyMW6uaMRgHhTphQ@mail.gmail.com>
References: <CALW=WECCELQOZpqB3foM6T+Qz+0v3hWT-mdTgCmGApEG4vxNcg@mail.gmail.com>
 <CAGAGxbZfDd5QaQ5iW+_pJzcHDHQztG_H_9JVyv4XT4BDaLVczw@mail.gmail.com>
 <CADUqk8UNnSL7C5_RDoNNFsdpuBoAFwdmzanaF9+GkeLN_gQkhQ@mail.gmail.com>
 <CAEZPtU44YsM1s_zJqPhAEu6cbqxh4k=A35qOd_z=XWErNf5wPA@mail.gmail.com>
 <5457AF2F.90808@php.net> <5457BDB7.8070701@garfieldtech.com>
 <CAFMT4NrgLzzpMt5Vm_Q84hXJ65U2jjqtLFm=ALYqwtiyxp0LjA@mail.gmail.com>
 <CAEZPtU4urLHc9FM0GohQJwkZD-TYKTVuPXcUMXsG5cAScHz3mw@mail.gmail.com>
 <54589A8D.3020607@sugarcrm.com> <CAEZPtU5qfcjCrcWRKW+ETF4uBp46rwVbv9nCdJoSUF+M+wKQdA@mail.gmail.com>
 <CAEPJdumXG9TC7xG8-YmGbQiwPMzwYvE_jXWvOQuNmz+U_=+ZaQ@mail.gmail.com>
 <1C3F4FA3-ABD5-4F6F-A898-F63AC1C723D5@ajf.me> <54591A76.8070302@sugarcrm.com>
 <967E30E5-71CB-40F8-9AE2-733D327DE197@ajf.me> <CAFp73XtxhW6t0k5TMa5n1ErC_7vur55Sa9oLtUM1P+X1Wugemg@mail.gmail.com>
 <545945A5.2090204@sugarcrm.com> <C12D441D-81CB-4270-8CE3-5A8BF2B27238@ajf.me>
 <CAFp73Xu++tT7fXE878i8CsibwNtiVJFcHQtzXi-iZA6=FXqeFA@mail.gmail.com> <CAFp73XuSaj4s3aqTfoOMCM6mAUM0BBncbRTyMW6uaMRgHhTphQ@mail.gmail.com>
Date: Wed, 5 Nov 2014 15:02:51 +0100
Message-ID: <CADyq6sLcYXxpyDzxrLVxS+5wgYYKh_TewgEcEAvg63p7LaNZqQ@mail.gmail.com>
To: "guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>
Cc: Andrea Faulds <ajf@ajf.me>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Benjamin Eberlei <kontakt@beberlei.de>, Pierre Joye <pierre.php@gmail.com>, 
	Levi Morrison <levim@php.net>, PHP internals <internals@lists.php.net>, 
	Larry Garfield <larry@garfieldtech.com>
Content-Type: multipart/alternative; boundary=001a11330fb447463505071d0a4d
Subject: Re: [PHP-DEV] Annotation PHP 7
From: ocramius@gmail.com (Marco Pivetta)

--001a11330fb447463505071d0a4d
Content-Type: text/plain; charset=UTF-8

Hi Guilherme,

On 4 November 2014 23:47, guilhermeblanco@gmail.com <
guilhermeblanco@gmail.com> wrote:

> Sorry, I forgot to add references to how we fixed emails handling. It got
> split in 2 places:
>
> - Initial root level annotation
>
> https://github.com/doctrine/annotations/blob/master/lib/Doctrine/Common/Annotations/DocParser.php#L350
>
> - Subsequent root level annotations
>
> https://github.com/doctrine/annotations/blob/master/lib/Doctrine/Common/Annotations/DocParser.php#L631
>

I'm not sure if we need that sort of syntax and opinionated approach: I
like Benjamin's approach better, and it is also simpler and still very easy
to use even in our context (doctrine).

For example, this alternative approach perfectly fits the current
doctrine/annotations use-case:

use Doctrine\ORM\Mapping\Entity;
use Doctrine\ORM\Mapping\Table;
use Doctrine\ORM\Mapping\Id;
use Doctrine\ORM\Mapping\GeneratedValue;
use Doctrine\ORM\Mapping\Column;

[Entity::class => []]
[Table::class => ['name' => 'foo_table']]
class Foo
{
    [Id::class => []]
    [GeneratedValue::class => [GeneratedValue::UUID]]
    [Column::class => ['name' => 'bar_column', 'type' => 'string']]
    private $bar;
}

I did nothing special here, just using plain old associative arrays and
built-in `::class` pseudo-constants: this leaves space for libraries that
do want to use annotations, but not the way doctrine/annotations does it
(calling the constructor of an annotation), and the annotations themselves
can still decide what to do with nested values.

No autoloading is going on, no code execution, nothing: plain and simple
arrays which may as well be used for phpdocumentor as well, if needed.

Greets,

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a11330fb447463505071d0a4d--