Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78700
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.214.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54527117.6000402@lerdorf.com>
References: <54527117.6000402@lerdorf.com>
Date: Wed, 5 Nov 2014 06:33:54 +0400
Message-ID: <CA+9eiLtDYtE+AWpS4FJnjiE=maDGyHE3uUz29dZ34k=J4og55A@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b41845b35250f050713692f
Subject: Re: opcache.revalidate_freq is PHP_INI_ALL?
From: dmitry@zend.com (Dmitry Stogov)

--047d7b41845b35250f050713692f
Content-Type: text/plain; charset=UTF-8

Hi Rasmus,

Sorry for delay, I'm just back to work after ZendCon and holidays.

opcache.revalidate_freq is PHP_INI_ALL on purpose.
Scripts that generate and include the same file again and again should set
it to 0 to check for modification on each include.

I didn't get what did you meant by "but it doesn't make any difference at
that poin", but I see that this re-validate logic may be implemented
improperly. Can you please check, if the following patch fixes the problem.

https://gist.github.com/dstogov/a7d3e136c6e857ff02b5

Thanks. Dmitry.




On Thu, Oct 30, 2014 at 8:10 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

>
> https://github.com/php/php-src/blob/master/ext/opcache/zend_accelerator_module.c#L259
>
> That looks suspicious to me and in simple testing doesn't appear to be
> the case. I mean, you can set it per-dir, but it doesn't make any
> difference at that point. Dmitry, could you go through the list of
> opcache directives in zend_accelerator_module.c and make sure the
> directives that are really only settable globally are marked as
> PHP_INI_SYSTEM?
>
> -Rasmus
>

--047d7b41845b35250f050713692f--