Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78677
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.181 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <76457381-6DBD-4C20-B18F-7CFB9D2EC55A@ajf.me>
References: <CA+sv8zB4TC_N_cZ6W_CkGZLXhFNTw23z-R197qEOT1v-VR4ksQ@mail.gmail.com>
	<CAH-PCH7=SZ710Pz5o80YSNRiAyRHivnoYt-A_OZbApDH7Jxc3Q@mail.gmail.com>
	<CAEKnhAFrSd0dMMER6rYpw2Y-SS4wMF1SLS83C-44RdiYdg+HHg@mail.gmail.com>
	<76457381-6DBD-4C20-B18F-7CFB9D2EC55A@ajf.me>
Date: Tue, 4 Nov 2014 20:06:20 +0000
Message-ID: <CAEKnhAF_Q042c474O2jo6=4h7+bVCRc4-WHR=NNMagD3dOE4kw@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, Juan Basso <jrbasso@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=90e6ba6147b8302a1705070dffd7
Subject: Re: [PHP-DEV] Add a new flag for json_encode
From: bukka@php.net (Jakub Zelenka)

--90e6ba6147b8302a1705070dffd7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Nov 4, 2014 at 6:14 PM, Andrea Faulds <ajf@ajf.me> wrote:

>
> > On 4 Nov 2014, at 17:07, Jakub Zelenka <bukka@php.net> wrote:
> >
> > I would really like to see it as default in the next major as it is a
> > useful feature.
> >
> > However I don't like adding new flag. The reason for that is that it
> > becomes useless after 7 is realesed. It would be useful only for >5.6.3
> and
> > <7.0 though. The only use case in PHP 7 would be just to disable the fl=
ag
> > but that won't be very nice and completely different than other json
> > constant usage It means doing something like $options &
> > ~JSON_PRESERVE_FRACTIONAL_PART ... It's a bit messy IMHO. Think that it
> > would be much better to wait till 7 with this feature.
>
> I really don=E2=80=99t like the idea of making this the default. On 32-bi=
t
> systems, floats give you, effectively, extra integer range up until you h=
it
> 2^52, and indeed all JS integer values are just floats within that range.=
 I
> don=E2=80=99t think they should be represented as floats. It=E2=80=99d go=
 weirdly with
> 64-bit PHP, which can decode such values to integers, which would then no=
t
> handle the range beyond 2^52 nicely.
>

That's a good point. However I still think that there are more advantages
for making this the default. I like mainly the idea that
json_decode(json_encode($a)) =3D $a for all floats which is not the case at
the moment. Also it allow some other things that were mentioned before.

Think that we will probably need an RFC for that as we apparently don't
have a consensus about this.

Cheers

Jakub

--90e6ba6147b8302a1705070dffd7--