Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78628
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 74.125.82.41 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU6yzMgHx1N6RHkmmxpHCJMhkrh1+0Fcr5tc47tM-johiQ@mail.gmail.com>
References: <CALW=WECCELQOZpqB3foM6T+Qz+0v3hWT-mdTgCmGApEG4vxNcg@mail.gmail.com>
	<CAGAGxbZfDd5QaQ5iW+_pJzcHDHQztG_H_9JVyv4XT4BDaLVczw@mail.gmail.com>
	<CADUqk8UNnSL7C5_RDoNNFsdpuBoAFwdmzanaF9+GkeLN_gQkhQ@mail.gmail.com>
	<CAEZPtU44YsM1s_zJqPhAEu6cbqxh4k=A35qOd_z=XWErNf5wPA@mail.gmail.com>
	<5457AF2F.90808@php.net>
	<5457BDB7.8070701@garfieldtech.com>
	<CAFMT4NrgLzzpMt5Vm_Q84hXJ65U2jjqtLFm=ALYqwtiyxp0LjA@mail.gmail.com>
	<CAEZPtU4urLHc9FM0GohQJwkZD-TYKTVuPXcUMXsG5cAScHz3mw@mail.gmail.com>
	<54589A8D.3020607@sugarcrm.com>
	<CAEZPtU5qfcjCrcWRKW+ETF4uBp46rwVbv9nCdJoSUF+M+wKQdA@mail.gmail.com>
	<CAEPJdumXG9TC7xG8-YmGbQiwPMzwYvE_jXWvOQuNmz+U_=+ZaQ@mail.gmail.com>
	<CAEZPtU6yzMgHx1N6RHkmmxpHCJMhkrh1+0Fcr5tc47tM-johiQ@mail.gmail.com>
Date: Tue, 4 Nov 2014 12:46:12 +0100
Message-ID: <CAEPJdumxQjv=kKRbMdz3UbdgNp+7Ei+VJMJ4dkyf=unzB9g3Ow@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>, Levi Morrison <levim@php.net>, 
	PHP internals <internals@lists.php.net>, Stas Malyshev <smalyshev@sugarcrm.com>
Content-Type: multipart/alternative; boundary=f46d04138c9f89db87050707028a
Subject: Re: [PHP-DEV] Annotation PHP 7
From: kontakt@beberlei.de (Benjamin Eberlei)

--f46d04138c9f89db87050707028a
Content-Type: text/plain; charset=UTF-8

On Tue, Nov 4, 2014 at 12:20 PM, Pierre Joye <pierre.php@gmail.com> wrote:

>
> On Nov 4, 2014 8:54 PM, "Benjamin Eberlei" <kontakt@beberlei.de> wrote:
> >
> > On Tue, Nov 4, 2014 at 11:28 AM, Pierre Joye <pierre.php@gmail.com>
> wrote:
> >>
> >> On Tue, Nov 4, 2014 at 4:21 PM, Stas Malyshev <smalyshev@sugarcrm.com>
> wrote:
> >> > Hi!
> >> >
> >> >> As I do consider personal tastes important, there are times where we
> should
> >> >> listen to our users.
> >> >
> >> > It would be nice to take "paving the walkways" approach, but last time
> >> > we tried, IIRC we've got into something very over-engineered. Maybe if
> >> > we try again with more restricted scope (i.e. not trying to put a DSL
> >> > for describing arbitrarily complex data structures into it :) it would
> >> > be more successful this time.
> >>
> >> All projects mentioned in this thread use:
> >>
> >>
> http://doctrine-common.readthedocs.org/en/latest/reference/annotations.html
> >>
> >> That makes a pretty good base spec.
> >
> >
> > Being the author I can say, the doctrine annotations project is way too
> over-engineered/special-purpose to land in core.
> >
> > I agree with Stas that a much simpler approach is probably realistic.
> >
> > beginning pure speculation here, i see a short array like syntax like:
> >
> > [foo="bar", bar="baz", baz=["key": "value"]]
> > function annotated_fn() {}
> >
> > Maybe even exactly short array syntax:
> >
> > ["foo"="bar", "bar"="baz", "baz"=["key": "value"]]
> > function annotated_fn() {}
> >
> > Then $reflectionFunction->getAnnotations() returns an array. Various
> PHP/Userland libraries and frameworks can then stick whatever symantic on
> top that they want.
>
> Yes, that was what discussed last time too and makes perfectly sense.
>
> I only not sure about the syntax. I do not like that one f.e. not really
> in phase with what exists (doctrine or other languages).
>
The problem with this simple approach is namespacing to avoid clashes, any
solution to incoperates that introduces lots of complexity like allowing
"new Annotation" inside the array definition.

However I guess now that for example composer provides namespaces for
packages, the community could come up with a convention to namespace by
composer package name to allow something like:

["doctrine/orm": ["entity"]]
class User
{
    ["doctrine/orm": ["id", "generatedvalue", "column": ["type":
"integer"]]]
    public $id;
}

The simplicity here is really key. Validation and mapping of this is much
easier implemented in userland code.

> Cheers,
> Pierre
>

--f46d04138c9f89db87050707028a--