Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78578
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.46 as permitted sender)
MIME-Version: 1.0
Sender: are.you.winning@gmail.com
In-Reply-To: <5452218C.7020303@beccati.com>
References: <CAHXmDMDNRB69aVsd8Ue9V0GKods0DT4XaNayi_rvw32BhrjUgg@mail.gmail.com>
	<5452218C.7020303@beccati.com>
Date: Mon, 3 Nov 2014 15:11:52 +0000
Message-ID: <CAGAGxbaOLebRQGQ9cR-nP9iZaE4v81bWAEF320yW7Pusbd0oGQ@mail.gmail.com>
To: Matteo Beccati <php@beccati.com>
Cc: Trevor Suarez <rican7@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c15d7e366a2b0506f5c4e9
Subject: Re: [PHP-DEV] [PR] DateTime RFC7231 constant
From: cw@daverandom.com (Chris Wright)

--001a11c15d7e366a2b0506f5c4e9
Content-Type: text/plain; charset=UTF-8

On 30 October 2014 11:31, Matteo Beccati <php@beccati.com> wrote:

> Hi,
>
> On 30/10/2014 08:03, Trevor Suarez wrote:
> > Good early morning (late night for me) internals!
> >
> > I would like to propose a small addition be made to the DateTime date
> > format constant definitions.
> >
> > https://github.com/php/php-src/pull/882
>
> Thanks for the PR.
>
> However, I'm afraid the comments on the PR code are correct. The output
> is supposed to be UTC time, not just local time with "GMT" appended.
>
>
This is true, and there isn't really a particularly good solution to this
if implementing this as a constant. However, it should be possible to add a
new format character for this (e.g. R) - the constant could be added as
well in this scenario, with value of the new character. This would be a
minor BC break. It's probably still worth considering for (5.)?7, since at
the moment the only way to definitely (and sanely) get this right every
time is via gmdate(), which may result in messy code when working with
DateTime etc objects.

Trevor, if you do want to look at implementing this for practice/improving
your C skills etc, it's not a particularly difficult task, it's largely
just a simpler version of the handling of "r", that does not consider the
localtime flag or generate the offset digits. The relevant part of the
source code is here:
http://lxr.php.net/xref/PHP_5_6/ext/date/php_date.c#1189

The "R" format character is available and probably makes the most sense of
the available possibilities, as the format approximately complements "r".

Thanks, Chris

--001a11c15d7e366a2b0506f5c4e9--