Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78550
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zort.net designates 96.241.205.2 as permitted sender)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
In-Reply-To: <CABBJUpdyMW_9r-FkxtOC3a2e4TS2J+dNTXN3sOYhw+KxLYjB4g@mail.gmail.com>
Date: Sat, 1 Nov 2014 14:35:16 -0400
Cc: Pierre Joye <pierre.php@gmail.com>,
        PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <CCD3FDBB-5905-4106-B6C9-634B53665030@zort.net>
References: <EB032A39-EB24-4BBE-A2D3-14BF63809873@zort.net> <CAEZPtU6PA1=jNPcQB5n4m1gYvfxBh_5MsEPHmvD_gAS8hHDyWA@mail.gmail.com> <CABBJUpdyMW_9r-FkxtOC3a2e4TS2J+dNTXN3sOYhw+KxLYjB4g@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Subject: Re: [PHP-DEV] [RFC] GitHub Pull Requests Triage Team
From: jbafford@zort.net (John Bafford)


On Nov 1, 2014, at 10:27, Xinchen Hui <laruence@php.net> wrote:

> Hey:
>=20
> On Sat, Nov 1, 2014 at 7:53 PM, Pierre Joye <pierre.php@gmail.com> =
wrote:
>> Hi,
>>=20
>> On Oct 31, 2014 4:57 AM, "John Bafford" <jbafford@zort.net> wrote:
>>>=20
>>> Hi,
>>>=20
>>> I would like to propose the creation of a team to triage the pull
>> requests on GitHub, to help ensure that the pull requests are handled =
in a
>> timely manner. I am also volunteering to lead such a team, should the =
RFC
>> be approved.
>>>=20
>>> https://wiki.php.net/rfc/github-pr
>>>=20
>>> PHP=92s GitHub repository has over 180 open pull requests. Many of =
these
>> are bug fixes or new tests that should be incorporated into PHP, but =
have
>> not been because the PRs aren=92t being regularly monitored. As a =
result, the
>> large number of open pull requests may also be discouraging =
contributions,
>> as potential contributors may see that pull requests are not being =
acted on
>> and decline to submit changes.
>>=20
>> As much as I like the idea I never understood why we do not have them =
here.
>>=20
>> Given that many PRs have discussions, it should show up on internals.
>>=20
>> PS: yes we have a PR list. Which did not work as expected. PRs and
>> discussions in them should not be considered as noises to the =
internals list
>> Cheers,
> Maybe we should create some tags , like "minor", "critical", "need =
verify" etc..
>=20
> for minors, anyone have time can merge it. (like typo fix).
>=20
> thanks

At the moment, I would be wary of trying to do too much at the start. =
Having a process and team in place for getting the PRs triaged is more =
important than also rating PRs for severity. Once we get this going and =
see how it=92s helping the overall workflow, we can better consider the =
best ways to expand from there.

Adding severity labels is certainly something that we can do in the =
future. I do note, though, that bugs.php.net does not appear to have a =
severity rating; tickets are only tracked according to =
bug/feature/docs/security, and the RFC currently has labels for the =
first three of those. I think if we=92re going to start adding =
additional labels that go beyond triage, we=92d want to coordinate that =
with bugs.php.net, and that=92s getting to be outside of the scope of =
this RFC.

Also: would we even want to add a label for security? If I=92m =
remembering correctly, PHP has a separate (and initially closed) process =
for tracking security issues, so we may not want to advertise that a PR =
is security related until after there=92s an official announcement. (I =
think this also means that PRs through GitHub are not likely to be =
security related. But I=92m open to comments/suggestions on the matter.)

-John=