Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78548
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain margaine.com from 209.85.223.172 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAGAGxbYuimpj+phbNXn_3e_17vpGEkes7Pn5jCh9j27uZoOT8Q@mail.gmail.com>
References: <CABRjmp_2DzhrGGoknZvSZ6fM=okjz+Od+2t0TVrNarc2fRLWiA@mail.gmail.com>
 <CAHMUw2HVmJD9syo8Rbc1=bA5S3U9umS0_XHFzwzWsY9Ee7UneQ@mail.gmail.com>
 <CAL+t6cEfbd7KbB=EbhdqgLKG6tBURgj+Ls9Y62tjOHL1Y+r-SA@mail.gmail.com>
 <CAH-PCH7tDQCtmAbPNOF4ONkeSQz5wr89XJ81a0USmzCqKi=26g@mail.gmail.com> <CAGAGxbYuimpj+phbNXn_3e_17vpGEkes7Pn5jCh9j27uZoOT8Q@mail.gmail.com>
Date: Sat, 1 Nov 2014 18:09:48 +0100
Message-ID: <CABRjmp8rdVmCPCA5xdfgUirCKg=kF3NHXYK0xmPgOxS+4sKc9w@mail.gmail.com>
To: Chris Wright <cw@daverandom.com>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, Sherif Ramadan <theanomaly.is@gmail.com>, 
	Tjerk Meesters <tjerk.meesters@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e013cc32c7f84680506cf2f09
Subject: Re: [PHP-DEV] setcookie() minor BC break - fixes issue #67736
From: florian@margaine.com (Florian Margaine)

--089e013cc32c7f84680506cf2f09
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi list,

On the PR <https://github.com/php/php-src/pull/795/> of the setcookie patch
to become compliant with the HTTP RFC, a valid use case for not throwing a
warning when running setcookie() twice with the same name: deleting cookies
(setcookie('name', '', ...);). It's thus been proposed to add an
unsetcookie() method.

I'm not set on whether it's a good thing or not. I'm also not sure how to
handle this.

There are some facts:

- the current way does not follow the HTTP RFC.
- we cannot have the "last come last served" cookie because it's a BC break=
.
- the current functions cannot allow us to unset a cookie.

What should be done? Trying to keep BC at a minimum by adding an
unsetcookie() method and add warnings? Try to detect the deletion of
cookies (empty value) and add warnings to keep even more BC?

I'm unsure on what should be done and would like internals' opinion :-)

On Tue, Sep 9, 2014 at 4:53 PM, Chris Wright <cw@daverandom.com> wrote:

> On 8 September 2014 09:09, Ferenc Kovacs <tyra3l@gmail.com> wrote:
> > On Mon, Sep 8, 2014 at 9:15 AM, Sherif Ramadan <theanomaly.is@gmail.com=
>
> > wrote:
> >
> >> Actually, we shouldn't be doing that all. We should simply just
> overwrite
> >> the header. It wouldn't make much sense to set two headers with the sa=
me
> >> cookie name when we can just overwrite it.
> >>
> >>
> >>
> > that would be a bigger BC break, and without a warning, those people
> > affected by the change will have a harder time figuring out what went
> wrong.
> > and as was discussed both in the PR and the bugreport the rfc discourag=
es
> > but doesn't prohibit this behavior, so making it impossible for the
> > userland to do it would be a bit of an arbitrary restriction.
> > maybe we could do something like introducing a new $overwrite =3D true
> option
> > to the function signature, but setcookie already has 7 arguments, so
> > probably isn't a great idea.
>
> --
> > Ferenc Kov=C3=A1cs
> > @Tyr43l - http://tyrael.hu
>

Regards,

--=20
Florian Margaine

--089e013cc32c7f84680506cf2f09--