Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78520
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 66.111.4.27 as permitted sender)
Content-Type: multipart/alternative; boundary="Apple-Mail=_BC0011F4-48BC-4594-9B50-F9FBDA71848E"
Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\))
In-Reply-To: <BF854E26-4029-4E36-AB2E-4C990C954286@ajf.me>
Date: Fri, 31 Oct 2014 13:15:35 -0400
Cc: John Bafford <jbafford@zort.net>,
 PHP internals <internals@lists.php.net>
Message-ID: <D098D708-37FA-4D3D-A7AD-5A5071543CFE@php.net>
References: <EB032A39-EB24-4BBE-A2D3-14BF63809873@zort.net> <BF854E26-4029-4E36-AB2E-4C990C954286@ajf.me>
To: Andrea Faulds <ajf@ajf.me>
Subject: Re: [PHP-DEV] [RFC] GitHub Pull Requests Triage Team
From: willfitch@php.net (Will Fitch)

--Apple-Mail=_BC0011F4-48BC-4594-9B50-F9FBDA71848E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252


> On Oct 31, 2014, at 12:10 PM, Andrea Faulds <ajf@ajf.me> wrote:
>=20
>=20
>> On 30 Oct 2014, at 21:57, John Bafford <jbafford@zort.net> wrote:
>> I would like to propose the creation of a team to triage the pull =
requests on GitHub, to help ensure that the pull requests are handled in =
a timely manner. I am also volunteering to lead such a team, should the =
RFC be approved.
>>=20
>> https://wiki.php.net/rfc/github-pr
>>=20
>> PHP=92s GitHub repository has over 180 open pull requests. Many of =
these are bug fixes or new tests that should be incorporated into PHP, =
but have not been because the PRs aren=92t being regularly monitored. As =
a result, the large number of open pull requests may also be =
discouraging contributions, as potential contributors may see that pull =
requests are not being acted on and decline to submit changes.
>=20
> Glad to see this, the pull request situation is really getting out of =
hand.

Ditto on this as well. We also need a better way of managing other PHP =
repository (e.g. PECL extensions) PRs.  I was just talking to Rasmus, =
Hannes and Ferenc about this today, and it appears the =
https://qa.php.net/pulls <https://qa.php.net/pulls> has been down for =
some time. =20

>=20
> I=92d like to make a small request, though. For RFCs, there should be =
a distinction between RFCs that haven=92t yet passed, which have pull =
requests mainly for code review purposes, and RFCs that have passed, =
which are waiting to be merged. Actually, it might be best to generally =
ignore RFC pull requests. For those that haven=92t yet passed, they just =
want someone to look at the code. For those that have, if the author has =
commit access, they don=92t need someone else to merge it, and the =
request is probably sticking around because the patch isn=92t yet fixed. =
The exception is pull requests for accepted RFCs by authors who lack =
commit access: for these, someone will need to go and merge them.
> --
> Andrea Faulds
> http://ajf.me/
>=20
>=20
>=20
>=20
>=20
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20


--Apple-Mail=_BC0011F4-48BC-4594-9B50-F9FBDA71848E--