Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:78513 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95439 invoked from network); 31 Oct 2014 16:43:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Oct 2014 16:43:18 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.208 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.208 imap2-3.ox.privateemail.com Received: from [192.64.116.208] ([192.64.116.208:38629] helo=imap2-3.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 16/72-15608-42CB3545 for ; Fri, 31 Oct 2014 11:43:17 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id DFE218C00C8; Fri, 31 Oct 2014 12:29:54 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap2.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap2.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lqezOJdgT72K; Fri, 31 Oct 2014 12:29:46 -0400 (EDT) Received: from oa-res-26-28.wireless.abdn.ac.uk (oa-res-26-28.wireless.abdn.ac.uk [137.50.26.28]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 0B1D28C0498; Fri, 31 Oct 2014 12:10:22 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) In-Reply-To: Date: Fri, 31 Oct 2014 16:10:20 +0000 Cc: PHP internals Content-Transfer-Encoding: quoted-printable Message-ID: References: To: John Bafford X-Mailer: Apple Mail (2.1990.1) Subject: Re: [PHP-DEV] [RFC] GitHub Pull Requests Triage Team From: ajf@ajf.me (Andrea Faulds) > On 30 Oct 2014, at 21:57, John Bafford wrote: > I would like to propose the creation of a team to triage the pull = requests on GitHub, to help ensure that the pull requests are handled in = a timely manner. I am also volunteering to lead such a team, should the = RFC be approved. >=20 > https://wiki.php.net/rfc/github-pr >=20 > PHP=92s GitHub repository has over 180 open pull requests. Many of = these are bug fixes or new tests that should be incorporated into PHP, = but have not been because the PRs aren=92t being regularly monitored. As = a result, the large number of open pull requests may also be = discouraging contributions, as potential contributors may see that pull = requests are not being acted on and decline to submit changes. Glad to see this, the pull request situation is really getting out of = hand. I=92d like to make a small request, though. For RFCs, there should be a = distinction between RFCs that haven=92t yet passed, which have pull = requests mainly for code review purposes, and RFCs that have passed, = which are waiting to be merged. Actually, it might be best to generally = ignore RFC pull requests. For those that haven=92t yet passed, they just = want someone to look at the code. For those that have, if the author has = commit access, they don=92t need someone else to merge it, and the = request is probably sticking around because the patch isn=92t yet fixed. = The exception is pull requests for accepted RFCs by authors who lack = commit access: for these, someone will need to go and merge them. -- Andrea Faulds http://ajf.me/