Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78453
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 66.111.4.27 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\))
In-Reply-To: <4ED7146272E04A47B986ED49E771E347BD7E35E061@Ikarus.ameusgmbh.intern>
Date: Thu, 30 Oct 2014 02:19:47 -0500
Cc: Alexander Lisachenko <lisachenko.it@gmail.com>,
 Stas Malyshev <smalyshev@gmail.com>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <51CF9ADE-2E04-4BC0-9E5C-B93498251F59@php.net>
References: <544DA1CD.9070109@php.net> <CAEbg-4YmUzuAEJZOqqCC=vJ=XY5b7HCZnj25B_JYxu1XJof_YQ@mail.gmail.com> <4ED7146272E04A47B986ED49E771E347BD7E35E061@Ikarus.ameusgmbh.intern>
To: Christian Stoller <stoller@leonex.de>
Subject: Re: [PHP-DEV] [RFC] Using objects as keys
From: willfitch@php.net (Will Fitch)


> On Oct 30, 2014, at 2:13 AM, Christian Stoller <stoller@leonex.de> =
wrote:
>=20
>=20
> From: Alexander Lisachenko [mailto:lisachenko.it@gmail.com], Sent: =
Monday, October 27, 2014 11:18 AM
>=20
>> Hello, internals!
>>=20
>>> The name __hash is not final, I am open to using __toKey instead or =
any
>>> reasonable alternative, we may also include a couple of options in =
the
>>> vote if that will be a point of disagreement.
>>=20
>> I like this idea with custom hash implementation because =
spl_object_hash()
>> is not reliable when objects are quickly created/destroyed, so hashes =
can
>> be the same for several different objects. However, will it be better =
to
>> introduce an interface for that? For example, Hashable can be a good =
name
>> (like Traversable one). Default implementation then can be a simple =
trait
>> that will be added later to the concrete class.
>=20
>=20
> I like the idea introducing an interface for this functionality, =
instead
> of adding a further magic method. But I think anything like "hash" or
> "hashable" is confusing for users.

The magic method is more of a PHP approach while an interface would be =
more appropriate.  That said, this RFC is a true representation of a =
hash vs something like spl_object_hash.  That=E2=80=99s what causes user =
confusion.  spl_object_hash would=E2=80=99ve been better served as a =
name like spl_object_id or spl_object_hash_id.  Something that indicates =
uniqueness regardless of the values of a particular object.

>=20
> Maybe something like=20
>=20
> interface ArrayKeyConvertable
> {
>    function toArrayKey();
> }
>=20
>=20
> Christian