Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78430
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
Message-ID: <544FA716.2030508@gmail.com>
Date: Tue, 28 Oct 2014 14:24:22 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <6E04B9BE-854E-4112-8C74-7D90BD8BFE95@ajf.me> <544D48A3.6070905@gmail.com> <572FEBD1-99A8-4788-83F9-D99E470FB16D@ajf.me> <544F4321.8040302@seld.be> <E87E48F1-5D79-4C6A-9368-C0A3CA35501F@ajf.me>
In-Reply-To: <E87E48F1-5D79-4C6A-9368-C0A3CA35501F@ajf.me>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Readonly Properties
From: rowan.collins@gmail.com (Rowan Collins)

Andrea Faulds wrote on 28/10/2014 14:08:
>> >On 28 Oct 2014, at 07:17, Jordi Boggiano<j.boggiano@seld.be>  wrote:
>> >
>> >I like it, except for the fact that if you add a custom getter to a property suddenly it becomes readonly unless you remember to add "; set" to the end of the block, right?
> Well, no. If you choose to specify getters and setters, and only specify a setter, of course it is read-only. It doesn’t make sense to have a getter and no setter and yet expect a property to be writeable.
>

I think the problem is that the get and set annotations are serving 
multiple purposes - to change the visibility, to define custom 
accessor/mutator code, but also to declare whether certain actions are 
possible at all. Since the default is for the property to be readable 
and writable, the fact that adding "{ get; }" makes it readonly isn't 
immediately intuitive, although it does makes sense once you think about it.