Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78428
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.216 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\))
In-Reply-To: <CAGAGxba5xcg7=fdM+QEd6-Q0fYurLNCANpnihhyiFbR_tNXTBg@mail.gmail.com>
Date: Tue, 28 Oct 2014 14:12:47 +0000
Cc: Rowan Collins <rowan.collins@gmail.com>,
 "internals@lists.php.net" <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <1B4C749F-7AD2-44A4-AEC3-C2781F14AE5E@ajf.me>
References: <6E04B9BE-854E-4112-8C74-7D90BD8BFE95@ajf.me> <544D48A3.6070905@gmail.com> <572FEBD1-99A8-4788-83F9-D99E470FB16D@ajf.me> <CAGAGxba5xcg7=fdM+QEd6-Q0fYurLNCANpnihhyiFbR_tNXTBg@mail.gmail.com>
To: Chris Wright <cw@daverandom.com>
Subject: Re: [PHP-DEV] [RFC] Readonly Properties
From: ajf@ajf.me (Andrea Faulds)


> On 28 Oct 2014, at 09:46, Chris Wright <cw@daverandom.com> wrote:
>=20
> Sorry, but I don't like this. This means that the visibility modifier =
is no longer next to the thing that it applies to,

I wouldn=E2=80=99t say that. The visibility modifier is an aspect of the =
property itself, not its implementation.  A property can be =
public-readable and private-writeable regardless of whether it=E2=80=99s =
a plain property or is a getter and a setter.

> IMO this is actually harmful to the readability because the order in =
which the accessors were defined then becomes significant

It wouldn=E2=80=99t be significant. The public/private doesn=E2=80=99t =
apply to the getters and setters, it applies to reading and writing from =
the property, regardless of its implementation.

If we did=E2=80=99t enforce order, got the read/write syntax and getters =
and setters, hypothetically this would be possible:

    public/private $foobar {
        set($value) { =E2=80=A6 }
        get { =E2=80=A6 }
    }

However, hopefully coding style guides would discourage that.

> I would suggest something like this:
>=20
> public $foobar {
>     get { return $this->bar * $this->foo; }
>     private set($value) { $this->bar =3D $value / $this->foo }
> }
>=20
> ...where only a single visibility modifier is permitted on the left, =
and this is treated as the *default* visibility for the accessors, which =
are free to declare another visibility if they want

I don=E2=80=99t like this, it=E2=80=99s moving the visibility again and =
having it split between the start and end of the declaration.
--
Andrea Faulds
http://ajf.me/