Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78415
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain seld.be designates 209.85.212.177 as permitted sender)
Message-ID: <544F4321.8040302@seld.be>
Date: Tue, 28 Oct 2014 07:17:53 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <6E04B9BE-854E-4112-8C74-7D90BD8BFE95@ajf.me> <544D48A3.6070905@gmail.com> <572FEBD1-99A8-4788-83F9-D99E470FB16D@ajf.me>
In-Reply-To: <572FEBD1-99A8-4788-83F9-D99E470FB16D@ajf.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Readonly Properties
From: j.boggiano@seld.be (Jordi Boggiano)

On 27/10/2014 20:27, Andrea Faulds wrote:
> Tentative syntax. But this way, the visibility stays on the left. I think that’s good for readability. If you omit the second specifier, then the first one applies to getting and setting, as now. If you include it, the first one applies to getting, the second one to setting.
>
> It’d also be compatible with properties, too:
>
>      public/private $foobar {
>          get { return $this->bar * $this->foo; }
>          set($value) { $this->bar = $value / $this->foo; }
>      }
>
> It doesn’t prevent truly read-only properties, either:
>
>      public $foobar {
>          get { return $this->bar * $this->foo; }
>      }
>
> Does this sound like a good idea? A similar idea came up in the discussions 8 years ago on readonly.

I like it, except for the fact that if you add a custom getter to a 
property suddenly it becomes readonly unless you remember to add "; set" 
to the end of the block, right?

How about this instead for readonly:

       public $foobar {
           get { return $this->bar * $this->foo; }; readonly
       }

And if the flag isn't there, set is implicitly present.

That'd mean you also can keep "public readonly $foobar;" as a shorthand 
for readonly properties without custom getter.

Cheers

-- 
Jordi Boggiano
@seldaek - http://nelm.io/jordi