Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78397
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.174 as permitted sender)
MIME-Version: 1.0
Sender: ekneuss@gmail.com
In-Reply-To: <544DA1CD.9070109@php.net>
References: <544DA1CD.9070109@php.net>
Date: Mon, 27 Oct 2014 18:39:26 +0100
Message-ID: <CACQesk7PV2KYnRWmF6wSKUGaXMjnLgvPKFmcJ0UZQroB5iqEZw@mail.gmail.com>
To: Stas Malyshev <smalyshev@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0117767de7885b05066b0419
Subject: Re: [PHP-DEV] [RFC] Using objects as keys
From: etienne.kneuss@epfl.ch (Etienne Kneuss)

--089e0117767de7885b05066b0419
Content-Type: text/plain; charset=UTF-8

On Mon, Oct 27, 2014 at 2:37 AM, Stas Malyshev <smalyshev@gmail.com> wrote:

> Hi!
>
> I would like to present to your attention an RFC about using object as
> keys:
>
> https://wiki.php.net/rfc/objkey
>
>

I think it should be made clear that what the target of your RFC is not to
support objects as keys, what you propose instead is an implicit
translation from:

$a[$obj]
to
$a[$obj->__hash()]

This is clearly different. And has at least one major drawback:

The object itself is not in the array, you cannot retrieve it by
foreach($arr as $obj => $v) { }.
=> This is quite counter-intuitive and counter-productive: one would expect
to find the object there, not its "hash".

As others noted, it also prevents a full-fledged objects-as-key
implementation in the future.

In the end it causes issues and brings very little compared to an explicit
call to convert an object to a key.

-1

-- 
Etienne Kneuss

--089e0117767de7885b05066b0419--