Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78287
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.178 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <CABBJUpeaWsUfrsHkKVFvVTFeV17vJwD3VPyARWoXs3c+wwLtvA@mail.gmail.com>
References: <6E04B9BE-854E-4112-8C74-7D90BD8BFE95@ajf.me>
	<CABBJUpeaWsUfrsHkKVFvVTFeV17vJwD3VPyARWoXs3c+wwLtvA@mail.gmail.com>
Date: Fri, 24 Oct 2014 06:11:36 +0200
Message-ID: <CAJW__o00EJvmTGOvMXVdBDrcBNR_how-=TJsZnErT8CjMaWSUg@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: Andrea Faulds <ajf@ajf.me>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Readonly Properties
From: kalle@php.net (Kalle Sommer Nielsen)

Hi

2014-10-24 5:02 GMT+02:00 Xinchen Hui <laruence@php.net>:
> Hey:
>
>    -1 on this.
>
>    Actually,   your example for explaining usage..
>
>     I don't see why it is must, add a getSize() will also meet the
> needs, and more beatiful, as you can change $size to another name if
> you like later.

I disagree on your disagreement, while it is not a must, it does not
make much sense that we are gonna call what essential is a function to
return a value that is not changed in anyway during that call. It does
not really perform a function, other than returning a value in 99% of
all cases, and therefore it makes perfect sense to allow readonly
properties in my mind.

It does not really make the code beautiful to prefix it with 'get' and
suffix it with '()' when you want such a value, it makes it
consistent, yes, but else it is just bloat to my eyes.

Internally it should also be a slightly be faster to not having to
call a method everytime as well, a program that does, lets say 50-100
calls to 'getX()' that can skip INIT_METHOD_CALL + DO_FCALL_BY_NAME
and instead just a FETCH_OBJ_R which is what should be after the
fcall, micro optimization I know (been a while since I went into these
parts so I might be a bit off though).

I'm a huge +1 on this, good job Andrea!


-- 
regards,

Kalle Sommer Nielsen
kalle@php.net