Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78216
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.218.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <866A39C7-6F11-408D-8BCA-594BA22E8569@ajf.me>
References: <66B7B28C-2651-4A71-AC2A-55D4C7BB3DDC@ajf.me>
	<CA+9eiLs9j0XMbtNKSSuqTBhF-BEc1CU__3E4gOhYwuF5zF4_1g@mail.gmail.com>
	<866A39C7-6F11-408D-8BCA-594BA22E8569@ajf.me>
Date: Wed, 22 Oct 2014 11:45:59 +0400
Message-ID: <CA+9eiLutEFyZsJGu9Qk9C7Jd0P48SBXcdRiVyySbqXbEYm3Y3w@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113e3afe86a5880505fe2324
Subject: Re: [PHP-DEV] [RFC] Safe Casting Functions
From: dmitry@zend.com (Dmitry Stogov)

--001a113e3afe86a5880505fe2324
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 22, 2014 at 2:51 AM, Andrea Faulds <ajf@ajf.me> wrote:

>
> > On 21 Oct 2014, at 10:14, Dmitry Stogov <dmitry@zend.com> wrote:
> >
> > some notes:
> > - it's probably make sense to implement these function as a new
> opcode(s) in VM
>
> That could be an optimisation later, yes. I note that you=E2=80=99ve adde=
d
> function replacement with opcodes for certain commonly-used functions. We
> could make these functions use that. Then they=E2=80=99d still be usable =
as
> callbacks.
>

I may help with implementation, if RFC accepted.
(It would be better if ZEND_STRLEN, ZEND_TYPE_CHECK, etc were introduced in
first place instead of stlen(), is_long() and family).



> > - in case of conversion failure it's better to throw exception (to_int(=
)
> returning FALSE is a pain).
>
> I am gradually warming to throwing an exception. An interesting idea I=E2=
=80=99ve
> had suggested on Twitter was by Matt Parker, who suggested that I add an
> optional 2nd argument. Without the argument, it throws an exception. With
> an argument, it returns that value (as a default) instead of throwing an
> exception.
>

Together with https://wiki.php.net/rfc/engine_exceptions_for_php7 throwing
exceptions would be the best choice. I would make it permanent, (without
optional areguments)

Thanks. Dmitry.


>
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>

--001a113e3afe86a5880505fe2324--