Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78163
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain strojny.net from 46.4.40.248 cause and error)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\))
In-Reply-To: <66B7B28C-2651-4A71-AC2A-55D4C7BB3DDC@ajf.me>
Date: Tue, 21 Oct 2014 01:27:43 +0200
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <9BB32AF2-E776-46CA-8604-0B5283B5050C@strojny.net>
References: <66B7B28C-2651-4A71-AC2A-55D4C7BB3DDC@ajf.me>
To: Andrea Faulds <ajf@ajf.me>
Subject: Re: [PHP-DEV] [RFC] Safe Casting Functions
From: lars@strojny.net (Lars Strojny)

Hi Andrea,

> On 21 Oct 2014, at 00:57, Andrea Faulds <ajf@ajf.me> wrote:
>=20
> Good evening,
>=20
> I am presenting a new RFC to add a set of three functions to do =
validated casts for scalar types:
>=20
> https://wiki.php.net/rfc/safe_cast
>=20
> Please read it.


I like the proposal except for one thing: the functions returning false =
in case of an error. As the next logical function would be "to_bool()", =
I foresee a lot of trouble with regards to API design as returning false =
there either means successful cast to false or an error while casting. =
What about changing the functions to take an $isError variable as a =
second argument?

$value =3D to_string(1.2, $isError);
if ($isError) {
   ...
}

Alternatively one could do the same thing with an $isSuccess variable:

$value =3D to_string(1.2, $isSuccess);
if (!$isSuccess) {
   ...
}

Thoughts?

cu,
Lars