Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78153
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fischer.name from 62.179.121.37 cause and error)
Message-ID: <54441174.5000303@fischer.name>
Date: Sun, 19 Oct 2014 21:31:00 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.2
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAFMT4No9Z-rDJ5s46vgrcOJPSxTDQZWs+K2myJt4H8517n=B=Q@mail.gmail.com>
In-Reply-To: <CAFMT4No9Z-rDJ5s46vgrcOJPSxTDQZWs+K2myJt4H8517n=B=Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Spam_score: -2.9
X-Spam_score_int: -28
X-Spam_bar: --
X-Spam_report: Spam detection software, running on the system "scanner01.home", has
 identified this incoming email as possible spam.  The original message
 has been attached to this so you can view it (if it isn't spam) or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  On 16.10.14 06:39, Levi Morrison wrote: > - The design and
    accompanying section of reflection[3] has been > rewritten entirely. > >
   [3]: https://wiki.php.net/rfc/returntypehinting#reflection I've some comments
    about the Reflection API addition/changes: [...] 
 
 Content analysis details:   (-2.9 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
Subject: Reflection-API (was: Re: [PHP-DEV] RFC: Return Types Update)
From: markus@fischer.name (Markus Fischer)

On 16.10.14 06:39, Levi Morrison wrote:
>   - The design and accompanying section of reflection[3] has been
> rewritten entirely.
> 
>   [3]: https://wiki.php.net/rfc/returntypehinting#reflection

I've some comments about the Reflection API addition/changes:

1. > "Note that getReturnType will always return a ReflectionType
object, even if there is no return type declared."

That feels weird, TBH. Other parts of the Reflection-API don't do that,
they simply return false if I would call e.g. getParentClass() when
there's none.


2. > "This API was designed so you could use ReflectionType::getKind()
in a switch statement to cover all cases, rather than be forced to use
an if/else structure that calls isArray(), isCallable, etc like the
ReflectionParameter API does."

I don't like the deviation from the existing Reflection API. I'm not
saying it's perfect, but I fear a "haystack,needle vs. needle,haystack"
thing here and would prefer the existing convention for is*() methods.

I wouldn't see a conflict it providing both as I see the usefulness.


3. The new class is called "ReflectionType", shouldn't it be
"ReflectionReturnType" ?


4. Other reflection classes, e.g. ReflectionParameter provides "missing
link" methods, specifically I'm missing:

public ReflectionClass getDeclaringClass ( void );
public ReflectionFunctionAbstract getDeclaringFunction ( void );


5. I think, also like in ReflectionParameter, there should a direct
shortcut to the class, if provided (and not just the string name):

public ReflectionClass getClass ( void );


thanks,
- Markus