Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78115
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.223.179 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <CAFMT4No9Z-rDJ5s46vgrcOJPSxTDQZWs+K2myJt4H8517n=B=Q@mail.gmail.com>
References: <CAFMT4No9Z-rDJ5s46vgrcOJPSxTDQZWs+K2myJt4H8517n=B=Q@mail.gmail.com>
Date: Thu, 16 Oct 2014 10:39:06 -0400
Message-ID: <CANaX5ndrPghjKsdWR6qxsR-wWnezOE8TRM1FAwUDj5QrdeJR6g@mail.gmail.com>
To: Levi Morrison <levi_morrison@byu.edu>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b3a9696ea145e05058b355a
Subject: Re: [PHP-DEV] RFC: Return Types Update
From: davey@php.net (Davey Shafik)

--047d7b3a9696ea145e05058b355a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I very much like this =E2=80=94 though I would say it was dependent on the =
nullable
types RFC (like splat and variadics were codependent).

While I would like to see the introduction of a void type, I understand and
respect the limitations on the RFC.

However, one thing that I do think is missing, is the equivalent of Hacks
`$this` return type. You have `self` and `parent`, but I think without a
`static` equivalent you can break things:

class foo {
     static public function instanceOf(): self {
           return new static();
     }
}

class bar extends foo { }

foo::instanceOf(); // new foo, this is fine, returns `self`.
bar::instanceOf(); // new bar, no longer `self`

On Thu, Oct 16, 2014 at 12:39 AM, Levi Morrison <levi_morrison@byu.edu>
wrote:

> Dear Internals,
>
> I finally have a working implementation for return types RFC[1] built
> on top of master. There are a few notes in the PR[2] about the
> implementation. I invite you all to review the PR and provide
> feedback.
>
> This means that I will soon move the return types RFC to voting phase.
> If you have not yet had time to review the RFC recently I invite you
> to do so now.
>
> The RFC has been slightly altered since the last discussion:
>   - The RFC now targets PHP 7 (previously PHP 5.7).
>   - There is a new section about disallowing return types on certain
> methods[4].
>   - The design and accompanying section of reflection[3] has been
> rewritten entirely.
>
> Regardless of the result of the RFC, I want to thank the many people
> who have been helpful to me as I have learned php-src and iterated
> over this RFC.
>
>   [1]: https://wiki.php.net/rfc/returntypehinting
>   [2]: https://github.com/php/php-src/pull/820
>   [3]: https://wiki.php.net/rfc/returntypehinting#reflection
>   [4]:
> https://wiki.php.net/rfc/returntypehinting#methods_which_cannot_declare_r=
eturn_types
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--047d7b3a9696ea145e05058b355a--