Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78092
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU5s9SQB93sQ7z1Xe0PdjFPU7jpeNUaaLWaM_LnLFpPsxA@mail.gmail.com>
References: <CAOv1iQbHuxbHK2KVk=jooNq41ThGkKkKRsQSLznsLJc0as3Q9A@mail.gmail.com>
 <CAGAGxbbexAyomc_C+21NjTd_e4H7Rep9OrtqwocowA1fvOZ92Q@mail.gmail.com>
 <CAEZPtU7TiLnU19UtG-Q+jUWJEPpJUyKZQoN3ZLnxO9pmUfhK5w@mail.gmail.com>
 <CAGAGxbaOZVr8f7GVyGGA7CdPuuioXcSH2mBBwz=3b69ic0YOEA@mail.gmail.com>
 <CAOv1iQb79ezCSEQX+nAgkxL-hSThoB9yMckKFKd98eO8146C5w@mail.gmail.com>
 <CAGAGxbZDxFOtA-WVb-QRLowof93HQ56HOfWMKyRVo7OY7VtHLw@mail.gmail.com>
 <CAOv1iQaFuFk4=eo2s5cMO9Uc+GQTRLL014+xOWKEeuN0ajNUKw@mail.gmail.com>
 <542214E2.5050800@sugarcrm.com> <CAEZPtU5s9SQB93sQ7z1Xe0PdjFPU7jpeNUaaLWaM_LnLFpPsxA@mail.gmail.com>
Date: Wed, 15 Oct 2014 10:41:30 +0200
Message-ID: <CAOv1iQZasmNHw4i1kvnywXLnwRyPLWHka85sTRs0iojM-3=o_A@mail.gmail.com>
To: Chris Wright <cw@daverandom.com>
Cc: Pierre Joye <pierre.php@gmail.com>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134c7b262bd280505721a5e
Subject: Re: [PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL
From: dunglas@gmail.com (=?UTF-8?Q?K=C3=A9vin_Dunglas?=)

--001a1134c7b262bd280505721a5e
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Chris,

I've just blogged about IDN support in PHP. This post include a (tiny)
userland implementation of streams:
http://dunglas.fr/2014/10/internationalized-domain-name-idn-and-php/

What do you think about the following to add native support :
1. As already stated, make ICU a dependency of core
2. Convert the host returned by php_parse_url here
https://github.com/php/php-src/blob/master/ext/standard/http_fopen_wrapper.=
c#L154
to Punycode with
http://icu-project.org/apiref/icu4c432/uidna_8h.html#a711fa1d2e6dd25d7368f5=
b3ea2aaedc6

It looks not so intrusive and relatively easy to implement. According to
RFC I quote in the blog post, it should work with SSL too. I can make a PR
(or a RFC if needed) with this method if it seems applicable.

Best regards,


2014-09-24 8:33 GMT+02:00 Pierre Joye <pierre.php@gmail.com>:

> On Wed, Sep 24, 2014 at 2:48 AM, Stas Malyshev <smalyshev@sugarcrm.com>
> wrote:
> > Hi!
> >
> >> I'll implement optional (and not default) support of IDN in
> filter_var().
> >>
> >> Does anyone known if it's better to use libIDN (LGPL) or ICU (custom
> >> license deviated from the X license) from a license point of view?
> >
> > ICU is definitely better since we already have a lot of code using ICU
> > and AFAIK our current IDN functions (idn_to_*) use ICU. Which means it
> > would be advantageous to keep it in the single library - whatever bugs
> > there may be, at least the user will be dealing with one set of bugs
> > instead of two :)
>
> Indeed :)
>
> However I am not sure yet we should do it, or at least not by default.
> It may introduce side effects or BC issues.While IDN is bi-directional
> or could be called many times and returning the same result, we have
> to be careful to do not break things out there, for example someone
> relying on it to process URI/URL.
>
> Cheers,
> --
> Pierre
>
> @pierrejoye | http://www.libgd.org
>



--=20
K=C3=A9vin Dunglas
Consultant et d=C3=A9veloppeur freelance

http://dunglas.fr
T=C3=A9l. : 06 60 91 20 20

--001a1134c7b262bd280505721a5e--