Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78089
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
Message-ID: <9c973e49d866a5b8bee27c2d89ceb992.squirrel@webmail.klapt.com>
In-Reply-To:
 <CAL9n4XOdPXgdH+0zKab8vh=WBBT+L6bkEBucQMi9F_cmt26q5A@mail.gmail.com>
References:
    <CAL9n4XOdPXgdH+0zKab8vh=WBBT+L6bkEBucQMi9F_cmt26q5A@mail.gmail.com>
Date: Wed, 15 Oct 2014 09:37:12 +0200
To: "Chris Tankersley" <chris@ctankersley.com>
Cc: internals@lists.php.net
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Fixes for Visual Studio 2014
From: anatol.php@belski.net ("Anatol Belski")

Hi Chris,

On Tue, October 14, 2014 15:35, Chris Tankersley wrote:
> Hello all.
>
>
> Partially fueled by a joke to get PHP to compile on Windows 10, and
> partially fueled by starting to look more into core, I found some issues
> with the javascript-based configuration under Windows 10 and Visual
> Studio
> 2014 as well as issues where VS2014 includes better C support than older
> versions of VS.
>
> https://github.com/php/php-src/pull/869
>
>
> The PR adds in some undefined checks for javascript variables, and some
> version checks for VS2014 to not load as much custom Windows header files
> from PHP.
>
> If someone could look at the PR I'd really appreciate it.
>
>
I saw the PR but had no chance yet to test it. Would come to it next weeks
if someone wasn't faster. Good to hear at least it works there with such a
small subset of changes.

Regards

Anatol