Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78019
Return-Path: <johannes@schlueters.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 7881 invoked from network); 14 Oct 2014 14:56:18 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 14 Oct 2014 14:56:18 -0000
Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error)
X-PHP-List-Original-Sender: johannes@schlueters.de
X-Host-Fingerprint: 217.114.215.10 mail.experimentalworks.net  
Received: from [217.114.215.10] ([217.114.215.10:60246] helo=mail.experimentalworks.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 5B/25-18603-1993D345 for <internals@lists.php.net>; Tue, 14 Oct 2014 10:56:18 -0400
Received: by mail.experimentalworks.net (Postfix, from userid 1003)
	id D094E44E58; Tue, 14 Oct 2014 16:56:28 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	km31408.keymachine.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=ALL_TRUSTED
	autolearn=unavailable version=3.3.2
X-Spam-HAM-Report: 
	* -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
Received: from [192.168.2.34] (ppp-93-104-7-33.dynamic.mnet-online.de [93.104.7.33])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: johannes@schlueters.de)
	by mail.experimentalworks.net (Postfix) with ESMTPSA id 0DA6D44E55;
	Tue, 14 Oct 2014 16:56:25 +0200 (CEST)
Message-ID: <1413298569.18696.14.camel@kuechenschabe>
To: Andrea Faulds <ajf@ajf.me>
Cc: Kristopher <kristopherwilson@gmail.com>, Andrey Andreev
 <narf@devilix.net>,  Kris Craig <kris.craig@gmail.com>, PHP internals list
 <internals@lists.php.net>
Date: Tue, 14 Oct 2014 16:56:09 +0200
In-Reply-To: <8CB055D4-F164-4DF3-B019-684BAE7E016E@ajf.me>
References: 
	<CAKOpQSwS=Xck41sQQyEYGG8L3VHq+fRWjy0dDorbwZaVWMLCow@mail.gmail.com>
	 <776669CE-9E8C-4069-9834-C7275CCA0EF4@ajf.me>
	 <CAKOpQSwRtSU1LNmftyY1b09SONBCfwS-qiMK4gct6uFiW3CSjw@mail.gmail.com>
	 <CAPhkiZwb13FmX+sQLx0Ki52KuwJ4HWTj-84UqcZq3GYPFL8Tnw@mail.gmail.com>
	 <E8F7D721-767C-4E6E-B0BB-F0DEFEB308B2@ajf.me>
	 <CAF9U7z_0cgwWFEoShU9rJhoOZttztcZk_NAqoXnSuAro-w3kew@mail.gmail.com>
	 <8CB055D4-F164-4DF3-B019-684BAE7E016E@ajf.me>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] New globals for PUT and DELETE
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Tue, 2014-10-14 at 14:29 +0100, Andrea Faulds wrote:
> * $_BODY    - request body parameters

I think this name is confusing and unclear. I don't have an alternative,
though. (Only suggestion: stick with the established name which can be
taught easily ("See method attribute in HTML <form> tag"), slightly
advanced users are used to it and don't really care, even more advanced
users use some framework/library providing higher level abstraction and
not having to care anymore, this leaves a few experts who know HTTP and
don't use a framework ... :-) )

And about the cost - mind that there always is an additional cost to any
change: Adoption to the environment. i.e. I assume there are multiple
people who scan for $_GET/$_POST/$_REQUEST/$_COOKIES/$_SERVER to find
input data while analyzing foreign code. Habits and tools need to
change.

Also when adding those the question is whether they should be true
aliases or not, i.e. what the result of

   $_GET['foo'] = 23;
   echo $_NEW_GET['foo'];

is.

For the latter I think any way is fine. And if we have good names I'm
open to add them, I don't consider $_BODY good, though. It has to be
short ($_HTTP_REQUEST_BODY certainly is too long) and precise, else
people stick with the comfortable thing taught in every book/tutorial.

johannes