Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77991 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65151 invoked from network); 14 Oct 2014 13:35:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Oct 2014 13:35:05 -0000 Authentication-Results: pb1.pair.com header.from=chris@ctankersley.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=chris@ctankersley.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain ctankersley.com from 209.85.215.47 cause and error) X-PHP-List-Original-Sender: chris@ctankersley.com X-Host-Fingerprint: 209.85.215.47 mail-la0-f47.google.com Received: from [209.85.215.47] ([209.85.215.47:63689] helo=mail-la0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AA/38-26074-9862D345 for ; Tue, 14 Oct 2014 09:35:05 -0400 Received: by mail-la0-f47.google.com with SMTP id pv20so8380811lab.6 for ; Tue, 14 Oct 2014 06:35:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=UYQhGSb8OC43ls2/X1Cx6CVDbKYv093lzxd8p/adqIQ=; b=Kvbcd5eBCFy5BYMJtWN7/bBE8ppawpvXaYxQDU4aNbeih6qbwmrHYl6GU3y4FT5k3R KADMzeLObWPvYZmrfC2aEh7u5Mj+meQzRT4Z5J4vzFJFgXA5gi8YF8loJALLf9ZPPpX5 KFc21KIjvyqrfhJtHv4K6Bi/+EnSjRW7Y87t3C3/0KtGNBRSlW0L1JkEqYntoDnXmcM5 pF8Y+QB2sRHB3jQeHal3x5oaF0yZgd45xQP3h/fY8xsTAuy9XOhGIqgjCz5Yb1WV6grW Y3hPEcj7SmSil0ddZZnEuSZM7TfIPLCbLN5/jh6QFlCOlNcX8vu+rtaBWw7/yCN8JYm9 LAWA== X-Gm-Message-State: ALoCoQnGdLpYsuKWP0LlPcEE9/GuGenq0LwH+1c/ASgnV/+2Pw7Deo8/RiV84m6qzf4wDyavuAQo MIME-Version: 1.0 X-Received: by 10.152.23.68 with SMTP id k4mr5259164laf.79.1413293702507; Tue, 14 Oct 2014 06:35:02 -0700 (PDT) Received: by 10.25.23.130 with HTTP; Tue, 14 Oct 2014 06:35:02 -0700 (PDT) X-Originating-IP: [184.57.105.84] Date: Tue, 14 Oct 2014 09:35:02 -0400 Message-ID: To: internals@lists.php.net Content-Type: multipart/alternative; boundary=089e0160b8661a07f60505621587 Subject: Fixes for Visual Studio 2014 From: chris@ctankersley.com (Chris Tankersley) --089e0160b8661a07f60505621587 Content-Type: text/plain; charset=UTF-8 Hello all. Partially fueled by a joke to get PHP to compile on Windows 10, and partially fueled by starting to look more into core, I found some issues with the javascript-based configuration under Windows 10 and Visual Studio 2014 as well as issues where VS2014 includes better C support than older versions of VS. https://github.com/php/php-src/pull/869 The PR adds in some undefined checks for javascript variables, and some version checks for VS2014 to not load as much custom Windows header files from PHP. If someone could look at the PR I'd really appreciate it. Thanks! -- Chris Tankersley http://ctankersley.com --089e0160b8661a07f60505621587--