Newsgroups: php.cvs,php.internals
Path: news.php.net
Xref: news.php.net php.cvs:82266 php.internals:77919
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <053301cfe6e2$dd954b60$98bfe220$@belski.net>
References: <35865ab5a49aa7711727174e173d0723.squirrel@webmail.klapt.com>
	<CA+9eiLu1fsRFMvP3B0T+kELjKxyPRt1rFEuGzcOZvdXF-F87Sg@mail.gmail.com>
	<57df99a6abdfeeb9036b529fb83175bd.squirrel@webmail.klapt.com>
	<CA+9eiLsJ-QjRbsZDiOyYL6QZ3oa=vibZ6=AvRUwOXshPAyZaJA@mail.gmail.com>
	<CA+9eiLumVZ0KzRNUyMe60_H5xV-ykQKMf3=3zmMK9iWtcT2rvw@mail.gmail.com>
	<3c0bcdbb4dcfbae062ad017e15b27db5.squirrel@webmail.klapt.com>
	<CA+9eiLvZ_6HmPpqjHNpd8ToXMY60roQcCPyRyVZzndfsioUU5Q@mail.gmail.com>
	<9aee6cbba7b350fc9cce8287d32c1a3c.squirrel@webmail.klapt.com>
	<b3f80e44656e591250a3282db8749643.squirrel@webmail.klapt.com>
	<ce63ec6bdfd6c25469d7cc3990223f21.squirrel@webmail.klapt.com>
	<CA+9eiLvsgpdKRjeMhg_gJJq-FMXOOQoTXunZrqXYc9i4r9ZKcQ@mail.gmail.com>
	<CA+9eiLtPLf-yCPsyUfY+r4FHaqvaFBVhAXxPFrsjJZ9yGuHhxA@mail.gmail.com>
	<053301cfe6e2$dd954b60$98bfe220$@belski.net>
Date: Mon, 13 Oct 2014 17:38:44 +0400
Message-ID: <CA+9eiLsUJg-q4e+9TuOfP-PJP7KrO6VesPFbOc0jTymNfHiN9A@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Joe Watkins <krakjoe@php.net>, Anatol Belski <ab@php.net>, Nikita Popov <nikita.ppv@gmail.com>, 
	"php-cvs@lists.php.net" <php-cvs@lists.php.net>, PHP Internals <internals@lists.php.net>, 
	Pierre Joye <pierre.php@gmail.com>, Xinchen Hui <laruence@php.net>
Content-Type: multipart/alternative; boundary=089e0149cb807a175105054e0455
Subject: Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in
 ZTS: Zend/zend.c
From: dmitry@zend.com (Dmitry Stogov)

--089e0149cb807a175105054e0455
Content-Type: text/plain; charset=UTF-8

bench.php should be faster as well. It must be slower because of not lucky
code locality or something like that.

Thanks. Dmitry.

On Mon, Oct 13, 2014 at 4:40 PM, <anatol.php@belski.net> wrote:

> Hi Dmitry,
>
> thanks for taking a look,
>
> On Mon, October 13, 2014 13:38, Dmitry Stogov wrote:
> > Hi Anatol,
> >
> >
> > At first, I still saw the same big difference on Linux.
> > bench.php ZTS - 1.340 sec, native TLS - 1.785 sec. As I understood, it
> must
> > be related to incomplete changes in build scripts, related to
> > ZEND_ENABLE_STATIC_TSRMLS_CACHE. Right?
> >
> Huh, not sure why the diff you get is so big. I guess it might be so with a
> full build. The bench results I was sending previously was done with
> --disable-all (actually more than that isn't needed for bench.php) on
> opensuse/x64. I have to check this. ZEND_ENABLE_STATIC_TSRMLS_CACHE
> conversions isn't complete, that's true.
>
> > If I get it properly, main PHP binary should be compiled with
> > -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 and shared extensions without it. It
> > should lead to quite fast code in main PHP binary and statically linked
> > extensions, but to slow code in shared extensions. Right?
> >
> With a small addition it is right. Actually any ext can possibly be
> compiled with -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1, just in accordance with
> the following
>
> - ext is static, then its SOMEEXT_G should just use ZEND_TSRMG instead of
> TSRMG
> - ext is shared, then the ext should
>     - ZEND_TSRMG
>     - use ZEND_TSRMLS_CACHE_DEFINE
>     - and ZEND_TSRMLS_CACHE_UPDATE at a proper place (globals ctor is a
> good one, maybe there's a better one)
>     - and possibly it can ZEND_TSRMLS_CACHE_EXTERN in some header to
> spread over multiple c files within the same ext
>
> - ext can be either/or static/shared, then at compile time it need to
> catch both cases. I made an exemplary conversion for ext/sockets. It can
> already switch to ZEND_TSRM which will use static or function call model
> to fetch TSRMLS, but it has to use COMPILE_DL_SOMEEXT && ZTS to check if
> it's a separate module (so it has to update it's local TSRMLS itself).
> - without -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 and steps above - an ext
> will always use TSRMG (so tsrm_get_ls_cache()) to fetch globals, but the
> good on that is - nothing will have to be touched and it'll work even if
> slower
>
>
> > I built PHP in this way with all extensions linked statically. Now, I see
> >  small slowdown on bench.php (however according to callgrind it executes
> > less instructions and should be faster). Wordpress became 2% faster.
> >
> > So the patch becomes interesting. :)
> > However, many distributions prefer shard extensions, and it would be
> great
> >  to invent some trick to make them fast too.
> So you could test it even more, but WP being faster with the current state
> is a bit surprising. But well :) Probably I gonna continue with some more
> conversions for the remaining exts and SAPIs, will also try to figure out
> why it could be possibly slower with bench.php, and then come back again.
>
>
> > I would also prefer to keep the semantic patch small and don't delete all
> >  FETCH_TSRM() in thousand places (at this point).
> > Replacing macro in one place must be easier.
> > It's not a problem to remove them on second step if the PoC would really
> > work.
> >
> I think one can apply a partial reverse patch for now, then all those
> places should be back. Probably easier than looking for all the
> corresponding commits. So I'll do it.
>
> Regards
>
> Anatol
>
>
>
>
>

--089e0149cb807a175105054e0455--