Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:7789
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Thu, 12 Feb 2004 12:37:35 -0800
To: Zeev Suraski <zeev@php.net>
Cc: internals@lists.php.net
Message-ID: <20040212203735.GA10260@gravitonic.com>
References: <cvszeev1076526934@cvsserver>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cvszeev1076526934@cvsserver>
User-Agent: Mutt/1.4.1i
Subject: Re: [PHP-CVS] cvs: php-src /ext/simplexml simplexml.c
From: andrei@gravitonic.com (Andrei Zmievski)

On Wed, 11 Feb 2004, Zeev Suraski wrote:
> zeev		Wed Feb 11 14:15:34 2004 EDT
> 
>   Modified files:              
>     /php-src/ext/simplexml	simplexml.c 
>   Log:
>   Prevent SimpleXML from silently modifying types of variables that are
>   assigned to its objects.
>   
>   Implementation notes for overloaded object modules:
>   
>   - If you return a zval which is not otherwise referenced by the extension
>     or the engine's symbol table, its reference count should be 0.
>   - If you receive a value zval in write_property/write_dimension, you
>     may only modify it if its reference count is 1.  Otherwise, you must
>     create a copy of that zval before making any changes.  You should NOT
>     modify the reference count of the value passed to you.

Can you put it in OBJECTS2_HOWTO or somewhere similar? It really should
be well documented.

- Andrei