Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77824
Return-Path: <tjerk.meesters@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 36804 invoked from network); 8 Oct 2014 00:33:28 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 8 Oct 2014 00:33:28 -0000
Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.41 as permitted sender)
X-PHP-List-Original-Sender: tjerk.meesters@gmail.com
X-Host-Fingerprint: 209.85.220.41 mail-pa0-f41.google.com  
Received: from [209.85.220.41] ([209.85.220.41:65126] helo=mail-pa0-f41.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 06/70-34162-75684345 for <internals@lists.php.net>; Tue, 07 Oct 2014 20:33:27 -0400
Received: by mail-pa0-f41.google.com with SMTP id eu11so8069826pac.14
        for <internals@lists.php.net>; Tue, 07 Oct 2014 17:33:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:content-type:content-transfer-encoding:subject:message-id:date
         :to:mime-version;
        bh=gpjbBXilBX/L69y+AUuzCYpTdAfEwU55D0AtpBbQg0M=;
        b=GevJIJvHXZGEm12nlxLiTlsfqnhK1DH0OBE1/blM+L2sbdjZPcCSDhFVtXmW43TipS
         hnXygHvcK5Hr0spHNBfZGQ0DvnFHEISc145mLElGQxJOpXxc7HUlZCk5/a2RN2oGcuGa
         hbHzTzCtfmUrt/gDXUIKgNyrNcqepyCUQITBnEf8dJxajDVGYXbQyZjsjwBPe3Qp+YIN
         CR2XihjytJA9TSNnJgccN1zVSdy0TEer7nsp+HrN9Qau99tMjsBC9b9V1W9m7IqNAkA4
         jH5z4jXscIbOVGmgML9kjOLb2IIqdwmGewL4VcxPUqa/oc1SIDMyddzIh9keFw5XdKrb
         CIQA==
X-Received: by 10.66.222.199 with SMTP id qo7mr5402977pac.134.1412728403049;
        Tue, 07 Oct 2014 17:33:23 -0700 (PDT)
Received: from [192.168.1.102] (bb121-7-198-24.singnet.com.sg. [121.7.198.24])
        by mx.google.com with ESMTPSA id nj3sm14811072pdb.70.2014.10.07.17.33.21
        for <internals@lists.php.net>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 07 Oct 2014 17:33:22 -0700 (PDT)
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Message-ID: <D1C505D1-5ABA-4AD6-B02B-AF0BE0F6F1F8@gmail.com>
Date: Wed, 8 Oct 2014 08:33:17 +0800
To: PHP Internals <internals@lists.php.net>
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
X-Mailer: Apple Mail (2.1878.6)
Subject: Fixes for (Recursive)RegexIterator
From: tjerk.meesters@gmail.com (Tjerk Meesters)

Hi,

I=92ve addressed bug #68128 with the following PR:

https://github.com/php/php-src/pull/865

As usual, I went in fixing one thing and ended up changing more until =
the results started to make sense.

I would appreciate another pair of eyes to glance over the changed code =
:)

Also, I=92m hoping to land this for a 5.6.x release as well; however, =
some existing test cases were adjusted due to the changed behaviour, so =
there=92s some BC we have to take note of.


Best,
  Tjerk=