Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77798
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4ED7146272E04A47B986ED49E771E347BD7DB8503E@Ikarus.ameusgmbh.intern>
References: <CAF+90c-7w1fLqmffYvPRhmtt8rzESEpSmW8vfMD-YfLt1mG_8w@mail.gmail.com>
	<CA+kxMuROMzNDn0ivobDXj7BC4SQXzkW8dCLQxpH8r75tP2x0eA@mail.gmail.com>
	<4ED7146272E04A47B986ED49E771E347BD7DB8503E@Ikarus.ameusgmbh.intern>
Date: Tue, 7 Oct 2014 14:15:55 +0200
Message-ID: <CAH-PCH6QO+t46EPE4F1a-F8rdQs7Srdy3aV-BPJ96vzux6HGgg@mail.gmail.com>
To: Christian Stoller <stoller@leonex.de>
Cc: Dan Ackroyd <danack@basereality.com>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c1c9c847f8b70504d429ca
Subject: Re: [PHP-DEV] [RFC] Exceptions in the engine
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a11c1c9c847f8b70504d429ca
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 7, 2014 at 11:51 AM, Christian Stoller <stoller@leonex.de>
wrote:

> From: Dan Ackroyd [mailto:danack@basereality.com] ,Sent: Tuesday, October
> 07, 2014 10:55 AM
> >
> > Stas wrote:
> >
> >> The only issue I think we need to discuss is catch(Exception $e). Now =
it
> >> would catch much more than before, if we do no changes.
> >
> > It's not clear why would that be an issue - can you specify what the
> > problem would be?
> >
> > Also, if we changed `catch(Exception $e)` to not catch all exceptions,
> > than we would need to have another way of specifying that a catch
> > block should catch all exceptions. Which would involve either making
> > \Exception extend another even 'baser' Exception, or a hack to the
> > syntax e.g. something like:
> >
> > catch($e) {
> >     // Catch without Exception type catches all exceptions
> >     // and confuses people.
> > }
> >
> > cheers
> > Dan
> > Ack
>
> We could make EngineException to be parent of the base Exception class.
> And, if it is technically possible, it must be forbidden to extend
> EngineException directly in userland.
>
> This is just an idea. It would be a little bit strange if Exception is
> not the base exception class ;) but it makes sense, because EngineExcepti=
on
> is an exception of all other exceptions ^^
>
> Christian
>

yes, this was also suggested before, but that will be also a BC break for
those people already using the name of the new parent class (
https://github.com/search?l=3Dphp&q=3DEngineException&type=3DCode&utf8=3D%E=
2%9C%93
for example).
which can be still an ok decision, I'm just stating/repeating the pro/cons
as this was all discussed before.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a11c1c9c847f8b70504d429ca--