Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77787
Return-Path: <tjerk.meesters@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 59519 invoked from network); 5 Oct 2014 22:23:55 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 Oct 2014 22:23:55 -0000
Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.169 as permitted sender)
X-PHP-List-Original-Sender: tjerk.meesters@gmail.com
X-Host-Fingerprint: 209.85.192.169 mail-pd0-f169.google.com  
Received: from [209.85.192.169] ([209.85.192.169:59486] helo=mail-pd0-f169.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id A2/A2-43691-9F4C1345 for <internals@lists.php.net>; Sun, 05 Oct 2014 18:23:54 -0400
Received: by mail-pd0-f169.google.com with SMTP id w10so2295524pde.14
        for <internals@lists.php.net>; Sun, 05 Oct 2014 15:23:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=subject:mime-version:content-type:from:in-reply-to:date:cc
         :content-transfer-encoding:message-id:references:to;
        bh=t/m3DTj/CvpaiZgjfci55wOZV402rcC7PnMgY4pf5SY=;
        b=G0mRIkOgsqul0MO0hLCsJhUvrDqPNe1KA8P0HQDn3APvJwjYU9Lk2yeYhywZDPIxM0
         X6KwhRxf3uTNxbA21U4dMlIn+2XeBlgIsoaDViNl1mBCFZ1RkKn8bgKQ51QrjDGWqBeP
         wZoGcAin0SzL+XzH6pDQ4Iwzo76uBFDZDETkuxe0v3Bt0Z/Yy6ThmatNcqsnGWNqCGYI
         GIizb2SUNy9r+kXH3Mwg0U4DU104TP9eUC+80G7PRczvxNZpO7AclpZaVf8ZED4ODYXG
         MiItw+2irmnlpfFa6m2iFncU7HYozOoR15sYeZJS+HBfu0LgTDSdYoA8mspRowtDcTwP
         SRIA==
X-Received: by 10.70.53.103 with SMTP id a7mr12398718pdp.34.1412547830482;
        Sun, 05 Oct 2014 15:23:50 -0700 (PDT)
Received: from [192.168.1.102] (bb121-7-198-24.singnet.com.sg. [121.7.198.24])
        by mx.google.com with ESMTPSA id d4sm9403869pdk.41.2014.10.05.15.23.48
        for <multiple recipients>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Sun, 05 Oct 2014 15:23:49 -0700 (PDT)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: text/plain; charset=windows-1252
X-Priority: 3
In-Reply-To: <812918912.244806.1410802971597.open-xchange@oxbaltgw01.schlund.de>
Date: Mon, 6 Oct 2014 06:23:44 +0800
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <64E878E1-0CAB-4630-96E1-468C1B1932C4@gmail.com>
References: <1920214534.158560.1408205362980.open-xchange@oxbaltgw06.schlund.de> <812918912.244806.1410802971597.open-xchange@oxbaltgw01.schlund.de>
To: Timm Friebe <php@thekid.de>
X-Mailer: Apple Mail (2.1878.6)
Subject: Re: [PHP-DEV] Can someone merge `Catchable "Call to a member function bar() on a non-object"`?
From: tjerk.meesters@gmail.com (Tjerk Meesters)

Hi!

On 16 Sep 2014, at 01:42, Timm Friebe <php@thekid.de> wrote:

> Hi everyone,
>=20
>> Timm Friebe <php@thekid.de> hat am 16. August 2014 um 18:09 =
geschrieben:
>> two weeks ago, the RFC `Catchable "Call to a member function bar() on =
a
>> non-object"` was accepted by a vote. I don't have commit access to
>> php-src/Zend,
>> so I can't commit this myself. Back from my summer vacation, I =
thought I'd
>> whip
>> up this email (after bringing the pull request up-to-date and making =
it
>> mergeable once again) and ask whether someone here can review[1] and =
then
>> merge
>> the PR https://github.com/php/php-src/pull/647?
>>=20
>> Thanks in advance!
>=20
> Any news on this? Is there anything left I need to do to get this =
merged? Should
> I apply for Zend/ karma?

It=92s been merged; due to my deceptive eyes and the similarity between =
the PR numbers (647 vs 847), I=92ve merged 647 instead and then added =
the test cases that were written for 847.

The end result should be the same and certainly all test cases passed =
(safe for those involving mysql tests); I=92ll check the Travis results =
when they come back.

My apologies on the somewhat messy push for this :(

>=20
> -Timm
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20