Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77749
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain margaine.com from 209.85.223.173 cause and error)
MIME-Version: 1.0
In-Reply-To: <542DB1A2.3040507@sugarcrm.com>
References: <CAF+90c9b6aRNNvJ6QVmumGgBW8=+dPxiByYY0h8M6x+L+BrYWQ@mail.gmail.com>
 <CAF+90c8Zt9DndV6WV+RJ1A+HgeG8LJ_Y2MATYtWi7=zB2ejEzw@mail.gmail.com>
 <542DA1A9.6020804@sugarcrm.com> <CABRjmp-4eeZ1UcFkOF62gtpRdMtbhfgk15y9bi56yZ=m+hVSwA@mail.gmail.com>
 <542DB1A2.3040507@sugarcrm.com>
Date: Thu, 2 Oct 2014 22:30:46 +0200
Message-ID: <CABRjmp_z0z3V2i0t2QYptWpYkNVzvr0UuQc4kbwE2KJvXqj5bQ@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>, Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=047d7bd6c11af67b290504767e15
Subject: Re: [PHP-DEV] Re: Remove generated lexers from git?
From: florian@margaine.com (Florian Margaine)

--047d7bd6c11af67b290504767e15
Content-Type: text/plain; charset=UTF-8

Hi,

On Thu, Oct 2, 2014 at 10:12 PM, Stas Malyshev <smalyshev@sugarcrm.com>
wrote:

> Hi!
>
> > Sorry to intrude, but why would building be harder? Tbh I don't see the
>
> Because there are more dependencies and tools needed to build the
> parsers. You'd have to have recent re2c, for example. Which does not
> come by default with many systems. I see no reason to add this hurdle
> with no benefit for anybody.
>

It's already necessary; PHP won't pass the configure step without re2c.


>
> > Also, there may be a small number of "big diffs", but one is enough to
> > introduce a bug. Generating the file every time ensures there is no
> > hidden bug.
>
> Which bug? They are generated parsers from the same source, what kind of
> bug you're talking about?
>

Slipping in a malicious code in such a diff could easily go unnoticed, for
instance. Or simply going to the file to see the generated code, leave a
letter by mistake because the cat jumps on the keyboard, and there you go.
I just mean that such big diffs are simply unreviewable; you have to trust
that it was generated and not touched after. Why this unnecessary trust to
give, when we can simply not have the file?


>
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
>



-- 
Florian Margaine

--047d7bd6c11af67b290504767e15--