Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77747 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62846 invoked from network); 2 Oct 2014 19:59:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Oct 2014 19:59:29 -0000 Authentication-Results: pb1.pair.com header.from=florian@margaine.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=florian@margaine.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain margaine.com from 209.85.213.172 cause and error) X-PHP-List-Original-Sender: florian@margaine.com X-Host-Fingerprint: 209.85.213.172 mail-ig0-f172.google.com Received: from [209.85.213.172] ([209.85.213.172:50703] helo=mail-ig0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4F/25-33841-0AEAD245 for ; Thu, 02 Oct 2014 15:59:28 -0400 Received: by mail-ig0-f172.google.com with SMTP id r2so1424652igi.11 for ; Thu, 02 Oct 2014 12:59:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=sL6PitmyMR0QUslcA1Nc7juqvZZBMGtq6wFjI1tsQ5E=; b=Hs0wEFOepjUewS//scrS4i5MxPglTP+66IRirJSZ/itjenSSWkSzkv5PJ8EH3waUN9 dwWf2/sDhsCDvBgbuhjvZOMu23uu3SyAHnuCgceLcwpa99nBQSm2kfF9N/iu9tDTey9f UR00TXqk1cR9/Lt0EGXifm6e0WcUfkeaQ+NhsRViuRsFycIUMfE7SonGNmVhZj4oAkzd wrwqiHkXWdo2Gd3kRhO6SYxwTCWPN8iy2iD5MCBnT04AsIbd0+CQRraIStj0B3KuqTzy EM2BvWwcCwY7PbhrYjC7AhgaKVkfV4NU8HdvNkolLcyvZYeHxlB2IqtL/KF76c1yWD7T Gv1g== X-Gm-Message-State: ALoCoQnx+/MLNzuOCHSUSnycYB8aZ2oRnGMjeE1h1jHiCE4tMVuSptBVmCnRT98G+XSn2ZOq1bnw MIME-Version: 1.0 X-Received: by 10.43.129.138 with SMTP id hi10mr7509257icc.73.1412279965369; Thu, 02 Oct 2014 12:59:25 -0700 (PDT) Received: by 10.107.5.194 with HTTP; Thu, 2 Oct 2014 12:59:24 -0700 (PDT) X-Originating-IP: [89.92.205.106] Received: by 10.107.5.194 with HTTP; Thu, 2 Oct 2014 12:59:24 -0700 (PDT) In-Reply-To: <542DA1A9.6020804@sugarcrm.com> References: <542DA1A9.6020804@sugarcrm.com> Date: Thu, 2 Oct 2014 21:59:24 +0200 Message-ID: To: Stas Malyshev Cc: PHP Internals , Nikita Popov Content-Type: multipart/alternative; boundary=001a11c1df2ca909600504760d07 Subject: Re: [PHP-DEV] Re: Remove generated lexers from git? From: florian@margaine.com (Florian Margaine) --001a11c1df2ca909600504760d07 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, Sorry to intrude, but why would building be harder? Tbh I don't see the point of keeping generated files in git. Why not keep release binaries too! (I'm kidding ofc.) Also, there may be a small number of "big diffs", but one is enough to introduce a bug. Generating the file every time ensures there is no hidden bug. Just my 2 cents. Regards, Florian Margaine Le 2 oct. 2014 21:04, "Stas Malyshev" a =C3=A9crit= : > Hi! > > > Case in point: The current zend_language_scanner.c has been generated b= y > > Andrea, who uses a different re2c version from everybody else (0.13.6 > > instead of 0.13.5). This means that if I do some tiny change to > > zend_language_scanner.l I immediately get a 3000 line diff. So we just > end > > up changing this file back and forth depending on the algorithm used by > > different versions. > > So, from time to time we'd get a big diff. But what's a big problem with > that? It doesn't seem to hurt anything. And language scanner is not > changed every day. I don't see any benefit in such change, just making > building PHP harder. > > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --001a11c1df2ca909600504760d07--