Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77746 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59223 invoked from network); 2 Oct 2014 19:04:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Oct 2014 19:04:15 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.83 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.83 smtp83.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.83] ([108.166.43.83:50611] helo=smtp83.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 18/A4-33841-DA1AD245 for ; Thu, 02 Oct 2014 15:04:14 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp3.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id DA42F1806A5; Thu, 2 Oct 2014 15:04:10 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp3.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 3D8F2180734; Thu, 2 Oct 2014 15:04:10 -0400 (EDT) X-Sender-Id: smalyshev@sugarcrm.com Received: from Stass-MacBook-Pro.local (108-201-189-144.lightspeed.sntcca.sbcglobal.net [108.201.189.144]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA) by 0.0.0.0:465 (trex/5.2.13); Thu, 02 Oct 2014 19:04:10 GMT Message-ID: <542DA1A9.6020804@sugarcrm.com> Date: Thu, 02 Oct 2014 12:04:09 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Nikita Popov , PHP internals References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Remove generated lexers from git? From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > Case in point: The current zend_language_scanner.c has been generated by > Andrea, who uses a different re2c version from everybody else (0.13.6 > instead of 0.13.5). This means that if I do some tiny change to > zend_language_scanner.l I immediately get a 3000 line diff. So we just end > up changing this file back and forth depending on the algorithm used by > different versions. So, from time to time we'd get a big diff. But what's a big problem with that? It doesn't seem to hurt anything. And language scanner is not changed every day. I don't see any benefit in such change, just making building PHP harder. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/