Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77742 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10630 invoked from network); 2 Oct 2014 04:48:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Oct 2014 04:48:12 -0000 X-Host-Fingerprint: 178.235.226.57 178235226057.olsztyn.vectranet.pl Received: from [178.235.226.57] ([178.235.226.57:24887] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0D/50-33841-909DC245 for ; Thu, 02 Oct 2014 00:48:11 -0400 To: internals@lists.php.net,nikita.ppv@gmail.com Message-ID: <542CD907.2040505@php.net> Date: Thu, 02 Oct 2014 06:48:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Posted-By: 178.235.226.57 Subject: Re: Remove generated lexers from git? From: sobak@php.net (Maciej Sobaczewski) Hello, sorry if I'm totally wrong - I have no experience in this area, but if someone is strongly against removing those files for any reason (not that I would) then we might consider passing -i flag while generating C files with re2c. As far as I can see most of the changes listed on every diff touching this file are different line numbers in comments. This option should disable them if only re2c documentation[1] is right. Regards, Maciej. [1]: http://re2c.org/manual.html > > I'd like to bring this up again. It seems the thread got side-tracked with > unrelated discussion (about vm_execute.h) and I didn't get any answers to > the original question. > > Case in point: The current zend_language_scanner.c has been generated by > Andrea, who uses a different re2c version from everybody else (0.13.6 > instead of 0.13.5). This means that if I do some tiny change to > zend_language_scanner.l I immediately get a 3000 line diff. So we just end > up changing this file back and forth depending on the algorithm used by > different versions. > > Nikita >