Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77730
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c9b6aRNNvJ6QVmumGgBW8=+dPxiByYY0h8M6x+L+BrYWQ@mail.gmail.com>
References: <CAF+90c9b6aRNNvJ6QVmumGgBW8=+dPxiByYY0h8M6x+L+BrYWQ@mail.gmail.com>
Date: Wed, 1 Oct 2014 00:34:44 +0200
Message-ID: <CAF+90c8Zt9DndV6WV+RJ1A+HgeG8LJ_Y2MATYtWi7=zB2ejEzw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bfd0bc671f31f05044ffdcc
Subject: Re: Remove generated lexers from git?
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7bfd0bc671f31f05044ffdcc
Content-Type: text/plain; charset=UTF-8

On Tue, Aug 26, 2014 at 9:55 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals!
>
> Currently our git repo contains files like zend_language_scanner.c,
> zend_ini_scanner.c, etc which are files generated by re2c. Historically
> these files have been included because re2c was not readily available on
> many platforms. In the thread on bison 3 compatibility [1] there was some
> discussion as to whether this limitation still applies. Quoting Adam Harvey:
>
> > +1. I don't think re2c is that onerous a requirement anyway, for the
> > most part: it's available through apt-get, brew, yum, and probably
> > most other packaging systems. Given the amount of other things a
> > developer has to install to build php-src from git, re2c is hardly
> > going to break the camel's back.
>
> So, I'd like to bring this up again. Are there any objections to removing
> generated lexer files from the repo? If not, does it suffice to just git rm
> them and add them to .gitignore, or are other changes required?
>
> Nikita
>
> [1]: http://markmail.org/message/x3p7ltekzws6ywhw
>

I'd like to bring this up again. It seems the thread got side-tracked with
unrelated discussion (about vm_execute.h) and I didn't get any answers to
the original question.

Case in point: The current zend_language_scanner.c has been generated by
Andrea, who uses a different re2c version from everybody else (0.13.6
instead of 0.13.5). This means that if I do some tiny change to
zend_language_scanner.l I immediately get a 3000 line diff. So we just end
up changing this file back and forth depending on the algorithm used by
different versions.

Nikita

--047d7bfd0bc671f31f05044ffdcc--