Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77632 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95238 invoked from network); 25 Sep 2014 20:32:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Sep 2014 20:32:07 -0000 Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.178 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 209.85.212.178 mail-wi0-f178.google.com Received: from [209.85.212.178] ([209.85.212.178:61196] helo=mail-wi0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C6/60-27297-6CB74245 for ; Thu, 25 Sep 2014 16:32:07 -0400 Received: by mail-wi0-f178.google.com with SMTP id z2so10269395wiv.11 for ; Thu, 25 Sep 2014 13:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/7TtIk7iKSrx4Qu6uBoiJQ1yWPL4S3kcLPEoHgYADpI=; b=SIdX0VrYw7L1nHzW8fqQtnmfxP0oggbt5EoPkMHKbLmlSzjvN9IbfM7HuXu0d8tvZh qgzMQP+vmFEm8+i21w3JWsGbk2zYfr6lF8mhyzF2Zese06LDOQQZWq0aSdjurbEzNE7v mCs60rp6kY1Ja9ynfDSFs82khpr/rJ0umVobqCK0WkXNsymRSb/w6Sx/8Z6CEr8+qxzE tsiLA39HU/XtP0SGC8xKJIjAML0ut5DjLQHiK1x0CKLcuL/a44Oz/EUN0Ux3VGMbnlGK CA8PmOnCTArkyb5lgUcSnRaozVBYI13HZg7Wny+K6Px80ZrNycehVfvUMJB+Kr+jdOmS icww== MIME-Version: 1.0 X-Received: by 10.194.57.67 with SMTP id g3mr18474722wjq.60.1411677123002; Thu, 25 Sep 2014 13:32:03 -0700 (PDT) Received: by 10.27.10.95 with HTTP; Thu, 25 Sep 2014 13:32:02 -0700 (PDT) In-Reply-To: References: Date: Thu, 25 Sep 2014 22:32:02 +0200 Message-ID: To: Dmitry Stogov Cc: Leigh , PHP Internals Content-Type: multipart/alternative; boundary=047d7ba977747446aa0503e9b195 Subject: Re: [PHP-DEV] [VOTE] Fix list() behavior inconsistency From: nikita.ppv@gmail.com (Nikita Popov) --047d7ba977747446aa0503e9b195 Content-Type: text/plain; charset=UTF-8 On Thu, Sep 25, 2014 at 1:15 PM, Dmitry Stogov wrote: > disabling string handling would allow make operation simpler and would > improve regular access to array elements. > We won't need to check for (opline->extended_value & ZEND_FETCH_ADD_LOCK) > in FETCH_DIM_R handler. > However, it's going to be very small improvement, and I don't care a lot. > :) > > enabling string handling would require complication of > ZEND_FETCH_DIM_TMP_VAR handler (for strings support). > It's going to make list() handling a bit slower, but not significantly. > > my choice +1 for disabling. > Could you please clarify why removing string support would make the operation simpler? I voted for always supporting strings because I thought that is the option that simplifies things - in particular it would allow use to drop the FETCH_DIM_TMP_VAR opcode and always go through FETCH_DIM_R instead. Sample patch here: https://github.com/nikic/php-src/compare/stringOffsetsInList Or did I miss something and we can't do that? Nikita --047d7ba977747446aa0503e9b195--