Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:776
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Mon, 7 Apr 2003 17:46:49 -0700 (PDT)
To: Christian Stocker <chregu@bitflux.ch>
cc: internals@lists.php.net
In-Reply-To: <1049764428.1584.48.camel@lappi.lappi.chregu.tv>
Message-ID: <Pine.LNX.4.44.0304071746140.895-100000@thinkpad.lerdorf.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] domxml memleak patches into PHP_4_3?
From: rasmus@lerdorf.com (Rasmus Lerdorf)
References: <1049764428.1584.48.camel@lappi.lappi.chregu.tv>

I think this should go in.  Like you said, for anything long-running, the 
current domxml is almost useless, so I would consider this a bug fix.

-Rasmus

On 8 Apr 2003, Christian Stocker wrote:

> Hi
> 
> (Mainly) Rob Richards and (just a tiny little bit) me were hunting down
> some domxml memleaks (and Rob implemented DomDocument->free() method.
> Hooray ;) ). As we are rather late in the release process of PHP 4.3.2,
> I'm not sure, if it's wise to commit them now to the PHP_4_3 branch or
> if I should wait until after this release.
> 
> Furthermore, the DomDocument->free() method was a much asked feature for
> domxml (and it really helps saving memory, if you want to process a lot
> of XML-Documents in one run). Would it be totally against the release
> rule if I add that function after 4.3.2 is released to the PHP_4_3
> branch?
> 
> Anyway, the diff file (against ext/domxml HEAD, not PHP_4_3 for the time
> being) can be found at http://trash.chregu.tv/domxml.memleak.diff, if
> anyone wants to use/test it right now
> 
> chregu
> 
> 
> 
> 
> 
> 
>