Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77569 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19000 invoked from network); 24 Sep 2014 06:33:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Sep 2014 06:33:46 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.47 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.192.47 mail-qg0-f47.google.com Received: from [209.85.192.47] ([209.85.192.47:36689] helo=mail-qg0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DE/A1-03797-9C562245 for ; Wed, 24 Sep 2014 02:33:46 -0400 Received: by mail-qg0-f47.google.com with SMTP id z107so5534266qgd.34 for ; Tue, 23 Sep 2014 23:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7Jg0VHueWW8dk65dddk7rwQhNMjNFTEm0Ltf32Fr7qc=; b=VNCLssodO/GvwnIM7z6BiA8T27ZbokEBXg/VUzkmdCw8W+yC3TPnVg59zPhKHXqDuH NpRhP5V7vzPDv+67C7bQNg8F4Jz6VgABwz0iqT1W0/FvgruZbchgzpyBMxpExaJ5gHG0 2R1xauAGDQQYvCI0Joek2TmPMir9W33aCCbO2htIf8q+amW/6vlIVatQ+yKKIOvEEbOd s2WCeGrHcc6JR8AxtbdQmQfjl5XK1NCYvE3DxHhGTm04jXiHWEnB64kU+5ePALzENCBf dm4NzzBqpOyuIgk/cVfQr2SzlHCKNQgGheUpUMyBuiXhlQrvASLRekryevNFmisi1CA/ 4hdg== MIME-Version: 1.0 X-Received: by 10.140.23.17 with SMTP id 17mr6752595qgo.30.1411540423539; Tue, 23 Sep 2014 23:33:43 -0700 (PDT) Received: by 10.140.22.51 with HTTP; Tue, 23 Sep 2014 23:33:43 -0700 (PDT) In-Reply-To: <542214E2.5050800@sugarcrm.com> References: <542214E2.5050800@sugarcrm.com> Date: Wed, 24 Sep 2014 08:33:43 +0200 Message-ID: To: Stas Malyshev Cc: =?UTF-8?Q?K=C3=A9vin_Dunglas?= , Chris Wright , PHP internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL From: pierre.php@gmail.com (Pierre Joye) On Wed, Sep 24, 2014 at 2:48 AM, Stas Malyshev wrote: > Hi! > >> I'll implement optional (and not default) support of IDN in filter_var(). >> >> Does anyone known if it's better to use libIDN (LGPL) or ICU (custom >> license deviated from the X license) from a license point of view? > > ICU is definitely better since we already have a lot of code using ICU > and AFAIK our current IDN functions (idn_to_*) use ICU. Which means it > would be advantageous to keep it in the single library - whatever bugs > there may be, at least the user will be dealing with one set of bugs > instead of two :) Indeed :) However I am not sure yet we should do it, or at least not by default. It may introduce side effects or BC issues.While IDN is bi-directional or could be called many times and returning the same result, we have to be careful to do not break things out there, for example someone relying on it to process URI/URL. Cheers, -- Pierre @pierrejoye | http://www.libgd.org