Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77505
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54212042.7060600@php.net>
References: <CAKOpQSyiCDEUDGhn50RuLL7ox_TJCCjD=4=qZ68OqbA5krXWkA@mail.gmail.com>
	<CAA8DMBsjORWTDKDncgbrWZKHmrn-=VQaRgxSpwhKoRC-RmE=4w@mail.gmail.com>
	<CAKOpQSx4FbBOyP+Q4NFrrVkRBGWdrZAfToVC6bvS_=wcpi2nrQ@mail.gmail.com>
	<CAA8DMBstOx6Nfr0DPy5VMiJNrFwZLYz5SKo9rSu_6WQCEByhuA@mail.gmail.com>
	<54212042.7060600@php.net>
Date: Tue, 23 Sep 2014 00:30:49 -0700
Message-ID: <CAKOpQSwn1NXYfeKTbO_sKExs7LeQWRvaTm8cmMRG_4xuOZD9Dw@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: Sanford Whiteman <figureonecpr@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0115ef9ae20e200503b68bd4
Subject: Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior
From: kris.craig@gmail.com (Kris Craig)

--089e0115ef9ae20e200503b68bd4
Content-Type: text/plain; charset=UTF-8

On Tue, Sep 23, 2014 at 12:24 AM, Michael Wallner <mike@php.net> wrote:

> On 2014-09-23 06:00, Sanford Whiteman wrote:
> >> What would happen is it'd throw an E_DEPRECATED for at least the
> remainder
> >> of 5.x, then throw the usual E_WARNING for a missing argument starting
> in
> >> 7.x with no default.
> >
> > Sounds OK to me now that I've noticed this:
> >
> >     https://bugs.php.net/bug.php?id=68081
> >
> > Pretty sure that's a sane report, and it's enough to make me say
> > checkdnsrr() doesn't work now at all.
>
>
> Given that this function is over 16 years old [1] and guessing that it
> was used as a simple kind of email domain verification, I think
> checkdnsrr() works as expected [2], [3].
>
> [1] http://marc.info/?l=php-internals&m=90222489331812&w=2
> [2] http://tools.ietf.org/html/rfc2821#section-5
> [3] http://tools.ietf.org/html/rfc5321#section-5.1
>
> --
> Regards,
> Mike
>

Except that it doesn't work as expected because most devs (including
myself) aren't readily familiar with posts from 1998.  And even if that
were its purpose back then, that really has no relevance today, as the
purpose and identity of PHP itself has evolved drastically since then.

If that really is a concern, though, then I would propose getting rid of
checkdnsrr() altogether (or making it an alias of checkmxrr()) and creating
a new general-purpose DNS lookup function that returns a boolean.  Of
course, I really don't think that's necessary since this stuff from 16
years ago doesn't have any meaningful bearing on how it's being used today
by modern PHP developers.

--Kris

--089e0115ef9ae20e200503b68bd4--