Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77448
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU51fnWWTnz5JCACA5VWw+5yoJhePe_H_AfNJUqxVfZonQ@mail.gmail.com>
References: <CAKOpQSyiCDEUDGhn50RuLL7ox_TJCCjD=4=qZ68OqbA5krXWkA@mail.gmail.com>
	<CAEZPtU48TxciS4ES5GVpn40wj_CXQWrABNjpN1BBV8jYRJdQjg@mail.gmail.com>
	<CAKOpQSw55PoiENViCrUKENZ4d-xUbjQJrvW5kuyhxfkuXN05JQ@mail.gmail.com>
	<CAEZPtU7PEVhtSSk2C0vWhN6kezCHNTs3HROpUL8UXpE14tGx3w@mail.gmail.com>
	<CAKOpQSyhhffu2ALZW6xxkokS_1X0L0aHbJmPTJPTPA_8NsX8sQ@mail.gmail.com>
	<CAEZPtU51fnWWTnz5JCACA5VWw+5yoJhePe_H_AfNJUqxVfZonQ@mail.gmail.com>
Date: Mon, 22 Sep 2014 02:56:50 -0700
Message-ID: <CAKOpQSyfnX4NZ4s7iDmm4wWRNWJa2VPF27kLiJShJLmoNyJgvg@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e011844ce4519b50503a478ef
Subject: Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior
From: kris.craig@gmail.com (Kris Craig)

--089e011844ce4519b50503a478ef
Content-Type: text/plain; charset=UTF-8

On Sep 22, 2014 2:16 AM, "Pierre Joye" <pierre.php@gmail.com> wrote:
>
> On Mon, Sep 22, 2014 at 10:56 AM, Kris Craig <kris.craig@gmail.com> wrote:
> >
> > On Sep 22, 2014 1:09 AM, "Pierre Joye" <pierre.php@gmail.com> wrote:
> >>
> >> On Mon, Sep 22, 2014 at 9:07 AM, Kris Craig <kris.craig@gmail.com>
wrote:
> >> >
> >> > On Sep 21, 2014 11:52 PM, "Pierre Joye" <pierre.php@gmail.com> wrote:
> >>
> >> Well, for what I can see users already take into account this part of
> >> the issue then:
> >>
> >> https://github.com/search?l=php&q=checkdnsrr&type=Code&utf8=%E2%9C%93
> >>
> >> changing the default will make create code compatibility between 5.x
> >> and 7.x, killing the gains we may have by changing the default.
> >>
> >> Cheers,
> >> --
> >> Pierre
> >>
> >> @pierrejoye | http://www.libgd.org
> >
> > That's why we have the option of just making that arg required without a
> > default, which would be targetted for PHP 7.
>
>
> I got that :)
>
> but now imagine one doing the following call now:
>
> checkdnsrr("myhost")  == TRUE
>
> where only MX was set and we suddenly change the default to ANY but
> ANY does not include MX, then the validation will simply fail and the
> code will become either:

Why doesn't ANY include MX?  That also seems counter-intuitive, as one
would assume that "ANY" would check for any type of record.

>
> checkdnsrr("myhost", 'MX')  == TRUE
>
> and for what I see, most of the usages are done to valid emails.

Hmm that hasn't been my experience, but regardless, they should be using
checkmxrr() for that, anyway.  As it stands now, the default behavior of
checkdnsrr() just redundantly mirrors the behavior of another function and
for no apparent reason.

>
> I am not saying I am against such changes, I only do not see the gains
> but the possible pains in a couple of situations, these pains will
> make migration harder with no technical gains from our side.

I do think it would be a usability gain, if not a technical one.  And I've
long been of the opinion that major version increments like PHP 7 are the
ideal time to implement such improvements, even despite some potential
edge-case BC.

What if we got rid of the option to change the default and instead just
went with making both args required?

--Kris

>
> Cheers,
> --
> Pierre
>
> @pierrejoye | http://www.libgd.org

--089e011844ce4519b50503a478ef--