Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77439 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5466 invoked from network); 22 Sep 2014 09:16:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Sep 2014 09:16:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.171 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.216.171 mail-qc0-f171.google.com Received: from [209.85.216.171] ([209.85.216.171:61303] helo=mail-qc0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 46/11-33885-EE8EF145 for ; Mon, 22 Sep 2014 05:16:30 -0400 Received: by mail-qc0-f171.google.com with SMTP id x3so5770007qcv.2 for ; Mon, 22 Sep 2014 02:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=n3U+nuRWDUaRWAbGw8QYmRs7yHeQdf5km5lyGQMXMJo=; b=NemmAZpWF9mUtSWuNfziwdnOKHRva4f1tGMyWU5XX0cGu+e1irIN2pYZSUaXvAVpkX uzbJ6CUTzZN221sjEzS7H9YlgQr4G0AhjbWpotmMZMZin19QmuIgcI02FEHknh8+TzQ2 07VZbZKlKC9Ojplig94RdqeqPQ8Pmk/VQeYxlFH6hZy9+Are74CDJFnBNqlKv6FR+0rX qKSAVZQOVXUTu7B2lFH7To7QgbE3zDME+XNiyDnTLveSlqXMJZRSmY4/cRMYIZr/XGg7 A04M2A/yaBjl9cvAQtGoX+ej8zUEQ0CBz7H8tAbBQCY9559sftfaftRc5fJcRGJ7Gq0I qJxA== MIME-Version: 1.0 X-Received: by 10.140.87.71 with SMTP id q65mr1100162qgd.94.1411377387844; Mon, 22 Sep 2014 02:16:27 -0700 (PDT) Received: by 10.140.22.51 with HTTP; Mon, 22 Sep 2014 02:16:27 -0700 (PDT) In-Reply-To: References: Date: Mon, 22 Sep 2014 11:16:27 +0200 Message-ID: To: Kris Craig Cc: PHP internals list Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior From: pierre.php@gmail.com (Pierre Joye) On Mon, Sep 22, 2014 at 10:56 AM, Kris Craig wrote: > > On Sep 22, 2014 1:09 AM, "Pierre Joye" wrote: >> >> On Mon, Sep 22, 2014 at 9:07 AM, Kris Craig wrote: >> > >> > On Sep 21, 2014 11:52 PM, "Pierre Joye" wrote: >> >> Well, for what I can see users already take into account this part of >> the issue then: >> >> https://github.com/search?l=php&q=checkdnsrr&type=Code&utf8=%E2%9C%93 >> >> changing the default will make create code compatibility between 5.x >> and 7.x, killing the gains we may have by changing the default. >> >> Cheers, >> -- >> Pierre >> >> @pierrejoye | http://www.libgd.org > > That's why we have the option of just making that arg required without a > default, which would be targetted for PHP 7. I got that :) but now imagine one doing the following call now: checkdnsrr("myhost") == TRUE where only MX was set and we suddenly change the default to ANY but ANY does not include MX, then the validation will simply fail and the code will become either: checkdnsrr("myhost", 'MX') == TRUE and for what I see, most of the usages are done to valid emails. I am not saying I am against such changes, I only do not see the gains but the possible pains in a couple of situations, these pains will make migration harder with no technical gains from our side. Cheers, -- Pierre @pierrejoye | http://www.libgd.org