Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77431
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain margaine.com from 209.85.213.177 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAOv1iQaZmp3jgCaEvD+oC_LEWLH_uf66E=Eq2uJoxu3NwUbKTg@mail.gmail.com>
References: <CABRjmp-P_HfBv956x2CdYuEdVr00wo9KnNLRBoBMdg185QvTiw@mail.gmail.com>
 <CAOv1iQZ=OfQsFaW=6dpoYZum10DjUfrhwvSAHAgXE7MeNV9dcA@mail.gmail.com>
 <CABRjmp89OYe4npqAPoAYSaAqHy0JTLrzAJUNx5rT2E7VWkvM+Q@mail.gmail.com> <CAOv1iQaZmp3jgCaEvD+oC_LEWLH_uf66E=Eq2uJoxu3NwUbKTg@mail.gmail.com>
Date: Mon, 22 Sep 2014 09:28:35 +0200
Message-ID: <CABRjmp9jXwxcNE_77f6Bo5mpuetouBtWbzc85rJuJFMeHVRcrQ@mail.gmail.com>
To: =?UTF-8?Q?K=C3=A9vin_Dunglas?= <dunglas@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e013cc16848c85e0503a2676c
Subject: Re: [PHP-DEV] #68049 filter_var echo wrong result for a url
From: florian@margaine.com (Florian Margaine)

--089e013cc16848c85e0503a2676c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Sounds like a great idea! Don't forget to update
https://bugs.php.net/bug.php?id=3D68049 when it'll be done.


Regards,

*Florian Margaine*

On Mon, Sep 22, 2014 at 9:20 AM, K=C3=A9vin Dunglas <dunglas@gmail.com> wro=
te:

> I've recently proposed a refactoring of FILTER_VALIDATE_URL:
> https://github.com/php/php-src/pull/826
> I can easily add the support of this new flag is everyone agree.
>
> 2014-09-22 9:09 GMT+02:00 Florian Margaine <florian@margaine.com>:
>
>> Oh, IE. *sigh*
>>
>> Adding a new flag sounds like a good idea indeed,
>> `FILTER_VALIDATE_UNCOMPLIANT_URL` sounds good enough?
>>
>> I guess it should accept underscores and domain names starting with
>> numbers too.
>>
>> Regards,
>>
>> *Florian Margaine*
>>
>> P.S: sorry Kevin for the double mail.
>> Le 22 sept. 2014 09:03, "K=C3=A9vin Dunglas" <dunglas@gmail.com> a =C3=
=A9crit :
>>
>>> Some browsers do. Some versions of IE are buggy when the URL include
>>> underscores:
>>> http://stackoverflow.com/questions/794243/internet-explorer-ignores-coo=
kies-on-some-domains-cannot-read-or-set-cookies
>>>
>>>
>>> I think that filter_var must follow the RFC by default. Maybe can we ad=
d
>>> a flag to allow malformed URL in use in the wild?
>>>
>>>
>>>
>>> 2014-09-21 10:42 GMT+02:00 Florian Margaine <florian@margaine.com>:
>>>
>>>> Hi,
>>>>
>>>> According to https://bugs.php.net/bug.php?id=3D51192 , valid URLs cann=
ot
>>>> contain underscores.
>>>>
>>>> The following bug was reported a couple days ago:
>>>> https://bugs.php.net/bug.php?id=3D68049
>>>>
>>>> The thing is, browsers *do* accept the underscore in URLs. Should the
>>>> rfc3986 <http://tools.ietf.org/html/rfc3986#section-3.2.2> be
>>>> respected, or
>>>> should PHP be lenient like browsers and accept more?
>>>>
>>>> Regards,
>>>>
>>>> *Florian Margaine*
>>>>
>>>
>>>
>>>
>>> --
>>> K=C3=A9vin Dunglas
>>> Consultant et d=C3=A9veloppeur freelance
>>>
>>> http://dunglas.fr
>>> T=C3=A9l. : 06 60 91 20 20
>>>
>>
>
>
> --
> K=C3=A9vin Dunglas
> Consultant et d=C3=A9veloppeur freelance
>
> http://dunglas.fr
> T=C3=A9l. : 06 60 91 20 20
>

--089e013cc16848c85e0503a2676c--