Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77418
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABRjmp90iMXa1mJZfKjsbakZfPmMdiXtwO=h8=C2CDfU1x0PHg@mail.gmail.com>
References: <CABRjmp90iMXa1mJZfKjsbakZfPmMdiXtwO=h8=C2CDfU1x0PHg@mail.gmail.com>
Date: Sun, 21 Sep 2014 22:43:34 +0100
Message-ID: <CAPg3XxK7ZhYPbm41MO0nKZ0QaNDucCCN1WzJuar+1nHXy6GdWA@mail.gmail.com>
To: Florian Margaine <florian@margaine.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2e224441e6505039a3c79
Subject: Re: [PHP-DEV] Request #67949 DOMNodeList should implement ArrayAccess
From: petercowburn@gmail.com (Peter Cowburn)

--001a11c2e224441e6505039a3c79
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 21 September 2014 12:39, Florian Margaine <florian@margaine.com> wrote:

> Hi list,
>
> The request is so that we can do this:
>
> $html =3D <<<HTML
> <div>data</div>
> HTML;
> $doc =3D new DOMDocument;
> $doc->loadHTML($html);
> var_dump($doc->getElementsByTagName('div')[0]->textContent);
>
> I started implementing this on my branch (
> https://github.com/Ralt/php-src/tree/issue-67949), but then I was
> thinking... ::offsetSet and ::offsetUnset don't really make sense in this
> context.
>
> From what I understand, SimpleXML does some magic to make it work without
> implementing ArrayAccess.
>
> I think it's cleaner to use ArrayAccess and to throw errors on ::offsetSe=
t
> and ::offsetUnset, but I'd like internals' opinion on this.
>

The DOM has a very specific API that we should be keeping to, and
encouraging developers to use.

I=E2=80=99d *much* rather see the DOM implementation completed (check out a=
ll of
the =E2=80=9Cnot implemented=E2=80=9D parts we have), than some shiny, shin=
y array-style
access to NodeList items. That said, people do like the shiny, shiny.


>
> Regards,
>
> *Florian Margaine*
>

--001a11c2e224441e6505039a3c79--