Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77396
Return-Path: <tjerk.meesters@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 67133 invoked from network); 21 Sep 2014 00:13:07 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Sep 2014 00:13:07 -0000
Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.181 as permitted sender)
X-PHP-List-Original-Sender: tjerk.meesters@gmail.com
X-Host-Fingerprint: 209.85.192.181 mail-pd0-f181.google.com  
Received: from [209.85.192.181] ([209.85.192.181:34171] helo=mail-pd0-f181.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 83/D1-55126-1181E145 for <internals@lists.php.net>; Sat, 20 Sep 2014 20:13:06 -0400
Received: by mail-pd0-f181.google.com with SMTP id r10so2176083pdi.40
        for <internals@lists.php.net>; Sat, 20 Sep 2014 17:13:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=references:mime-version:in-reply-to:content-type
         :content-transfer-encoding:message-id:cc:from:subject:date:to;
        bh=npDbGE0jyokIPNb2+vw8FwVA3kkitCIUqAK9SxEy5MY=;
        b=gpNR3LeSRu/Bkel6eeU/mnjnUfK5caLv5WvmrxIzquOhtd65+R5KERp8CT2ARJZFd6
         n4Zw3E2fM3ORFl1DToySY3CQoy1pS8KAWOCfxJXtDuxWjreX2pcev+h99hmT5RCVE81a
         YMYOiUPmizsDA8DhO1Fdur2F9Sd46Pap9svUoNCj4Kd0/IYLA8Okk2cSwvURYs3TwoZ4
         eKMTFxoeoIO9wq5v0aVHf+f0Eh50Obd/0O88udrO4HnQ5jwrCvR4gSwbK0lUVrao/wEf
         t6wviQ6Zd2w0lqmOY6Mdejrjy/W24aURTM2fCv6TMxZK/SPbJ8pUY4JXlfMDywnnkeoF
         YNTQ==
X-Received: by 10.70.88.37 with SMTP id bd5mr13039761pdb.89.1411258382463;
        Sat, 20 Sep 2014 17:13:02 -0700 (PDT)
Received: from [192.168.1.104] (bb121-7-198-24.singnet.com.sg. [121.7.198.24])
        by mx.google.com with ESMTPSA id fu3sm237720pdb.27.2014.09.20.17.13.00
        for <multiple recipients>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Sat, 20 Sep 2014 17:13:00 -0700 (PDT)
References: <CABRjmp9NQFeA7ASdp_eAKDvAJbwz0uWa2gt1_T8rBx9cDrXD=Q@mail.gmail.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <CABRjmp9NQFeA7ASdp_eAKDvAJbwz0uWa2gt1_T8rBx9cDrXD=Q@mail.gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-ID: <CDDA955B-A4FA-4A9E-ABAC-E16CBF23F262@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
X-Mailer: iPhone Mail (11D257)
Date: Sun, 21 Sep 2014 08:12:57 +0800
To: Florian Margaine <florian@margaine.com>
Subject: Re: [PHP-DEV] Bug #68063: session-related, how to fix it?
From: tjerk.meesters@gmail.com (Tjerk Meesters)


> On 20 Sep, 2014, at 11:35 pm, Florian Margaine <florian@margaine.com> wrot=
e:
>=20
> Hi list,
>=20
> I saw this interesting bug: https://bugs.php.net/bug.php?id=3D68063
>=20
> Basically, if `session_id('')` is run before `session_start()`, weird
> things happen.
>=20
> The bug reporter proposes 2 ways to fix this:
>=20
> - `session_start()` should silently fix the situation

I would opt for this, if an invalid session id is given a warning should be e=
mitted and a new id generated.=20

> - or `session_start()` should noisely fail
>=20
> Both solutions look fine to me, but I'm not sure what PHP should do. Shoul=
d
> it be resilient and silently fix the situation?
>=20
> Regards,
>=20
> *Florian Margaine*