Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77348
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.223.172 as permitted sender)
MIME-Version: 1.0
Sender: adam@adamharvey.name
In-Reply-To: <CAKOpQSzSpeX0PHAxbmWAKS=6K_yBu2x9tbmPGi98XdGZdjZnkg@mail.gmail.com>
References: <CAKOpQSygXa27qLQzfxKG9dnWpwxFns8TZb5-+ZxokJzPryk+hQ@mail.gmail.com>
 <CAGAGxbbu8O8OvPJsVh8bmBi9gmA0bV49hahYQ767rchOPRRS3w@mail.gmail.com>
 <CADajX4Cu_1LfshpuTdd8sMPhkgfgeBjzA=6iYnZEpHhd7-NryQ@mail.gmail.com> <CAKOpQSzSpeX0PHAxbmWAKS=6K_yBu2x9tbmPGi98XdGZdjZnkg@mail.gmail.com>
Date: Fri, 19 Sep 2014 10:54:30 -0700
Message-ID: <CADajX4AHKBv8LCyP3hGhkz217D0nv5Pqt4vZyXspP5tGHt3wmQ@mail.gmail.com>
To: Kris Craig <kris.craig@gmail.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Why does checkdnsrr() default to MX??
From: aharvey@php.net (Adam Harvey)

On 19 September 2014 10:51, Kris Craig <kris.craig@gmail.com> wrote:
> On Fri, Sep 19, 2014 at 10:24 AM, Adam Harvey <aharvey@php.net> wrote:
>> As an alternative, could we just make the type argument mandatory in
>> PHP 7 and start issuing E_DEPRECATED warnings if it's omitted in 5.6
>> or 5.7?
>
> I like both ideas.  Adam's approach would be more inconvenient for
> developers, but it would also be less of a BC issue since merely changing
> the default could cause some existing code to fail silently as opposed to
> generating an error.  On the other hand, I can't think of any such use ca=
se
> in which checking all DNS entries instead of just MX would cause any scri=
pts
> to break.  The only possible scenario I can think of would be if they're
> using dnsrr() to check if an MX record exists and hit a host that has an =
A
> record but not MX.  That would cause it to return TRUE when they're
> expecting FALSE.

I'm not a huge fan of silently making it ANY for the reason Sanford
explained elsethread =E2=80=94 it's a potential vector for amplification
attacks. I also don't think it's unreasonable to expect developers to
know what type of record they're interested in. :)

> I'll draft an RFC when I get a chance and include both options in it.

Thanks!

Adam