Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77323 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20732 invoked from network); 18 Sep 2014 22:52:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Sep 2014 22:52:32 -0000 Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.200 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.200 imap1-2.ox.privateemail.com Received: from [192.64.116.200] ([192.64.116.200:56718] helo=imap1-2.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 62/A2-07171-0326B145 for ; Thu, 18 Sep 2014 18:52:32 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 3A0A4B0008B; Thu, 18 Sep 2014 18:52:29 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap1.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap1.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bsrNbjAFHTjz; Thu, 18 Sep 2014 18:52:29 -0400 (EDT) Received: from oa-res-27-90.wireless.abdn.ac.uk (oa-res-27-90.wireless.abdn.ac.uk [137.50.27.90]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id DAABEB0008A; Thu, 18 Sep 2014 18:52:27 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) In-Reply-To: Date: Thu, 18 Sep 2014 23:52:24 +0100 Cc: internals@lists.php.net Content-Transfer-Encoding: quoted-printable Message-ID: References: To: =?windows-1252?Q?K=E9vin_Dunglas?= X-Mailer: Apple Mail (2.1878.6) Subject: Re: [PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL From: ajf@ajf.me (Andrea Faulds) On 18 Sep 2014, at 21:26, K=E9vin Dunglas wrote: > I'm working on enhancing the FILTER_VALIDATE_URL filter ( > https://github.com/php/php-src/pull/826). > The current implementation does not support validation of = internationalized > domain names (i.e: http://www.acad=E9mie-fran=E7aise.fr/ > ). >=20 > Support of IDN validation can be easily added using ICU's = uidna_toASCII() > function. >=20 > Is it acceptable to add a dependency to ICU for ext/filter? > Another option is to add a HAVE_ICU constant in main/php_config.h and = to > validate IDN only if ICU is present. >=20 > What strategy is preferred? Perhaps add a new filter that covers normal URLs and IDN ones? I just = imagine it might cause problems if suddenly IDNs are accepted, if there = is a backend which can=92t handle them. -- Andrea Faulds http://ajf.me/